Re: [PATCH 1/3] kernel/audit: audit_dummy_context can be boolean

Paul Moore
2015-09-29T18:23:58Z

On Tuesday, September 29, 2015 10:15:39 PM Yaowei Bai wrote:
> This patch makes audit_dummy_context return bool due to this
> particular function only using either one or zero as its return
> value.
>
> No functional change.
>
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> ---
> include/linux/audit.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Applied.

> diff --git a/include/linux/audit.h b/include/linux/audit.h
> index b2abc99..69844b6 100644
> --- a/include/linux/audit.h
> +++ b/include/linux/audit.h
> @@ -143,7 +143,7 @@ extern void __audit_inode_child(const struct inode
> *parent, extern void __audit_seccomp(unsigned long syscall, long signr, int
> code); extern void __audit_ptrace(struct task_struct *t);
>
> -static inline int audit_dummy_context(void)
> +static inline bool audit_dummy_context(void)
> {
> void *p = current->audit_context;
> return !p || *(int *)p;
> @@ -345,9 +345,9 @@ static inline void audit_syscall_entry(int major,
> unsigned long a0, { }
> static inline void audit_syscall_exit(void *pt_regs)
> { }
> -static inline int audit_dummy_context(void)
> +static inline bool audit_dummy_context(void)
> {
> - return 1;
> + return true;
> }
> static inline struct filename *audit_reusename(const __user char *name)