From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933497AbcA0Pvb (ORCPT ); Wed, 27 Jan 2016 10:51:31 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:57288 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932213AbcA0Pv2 (ORCPT ); Wed, 27 Jan 2016 10:51:28 -0500 From: Arnd Bergmann To: Mark Brown Cc: Johannes Berg , Simon Arlott , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage Date: Wed, 27 Jan 2016 16:51:11 +0100 Message-ID: <2271111.AdDD0dnl0s@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453908849-25166-1-git-send-email-broonie@kernel.org> References: <1453908849-25166-1-git-send-email-broonie@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:umoraseQDGvvcqB1z1QnirA0OUX6E5e3xhA7rDdnzfuNArTABd5 aifs2KYKKBnVwDuyh3hiOrQMyTUdavZcsUJMe1SfQoPEPVGKGJLF4odj7MUtaXbhge3Jwsc jmVGJuuG+fbP2quxcxTwaMd8ttlonN2Pgphr2oU5lkpF7SZ3AIUvOcoCQ8kvr9vWzH0Wc8W BCKZ9H8Vc0UBy34P0AgDQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7y6kFEdddUQ=:gVCFaAew41GMaE1MqVx5IJ YSJsvQH2gHOxI89d3qHGwBAVmImpe8IuH9vLpYmYQtxJbtpPK61VbMN3CLxCgP1goouc4FHbT 1GpoteoV7EResUZniHujLdgUGiJnei0SUWkCqTuTK7pe8mhbQySDyl7IUFb5PVcFvEw+rfBRv 7jyUlyvWYclrCF2gtRDYWVjEJZ1SQG77tz0l0Rhq82H2bFKnjJUB/kKEGzfiAQBHRLc31+aaj j+CkxTEom1Ge6BnAqN5KbHsEyu0cLbTQAlkf/TlvnNwhjz4p5lnOMTsSvhPEhliC02qAb44JP K08/89fpPJjG228bU0+p+6gEIMdiCDv+lcOG21UP7lh+9OjLEvoRXlRmhidLw26C/IJL5MSlk purOhidg24tE4VvKTaC1qYTs+UBcgWqaRFvOPCJigN0fVZObhfmtmQ7kQkt305zQlkZ4QZ02y RAqNW4BaOVIwXgGMMTjfxHE0EZzYCN6m7Hi5b9yhdLRL4quRn25UREV2Ek354eFErxBuq8Qk4 zYX3H6DfUpNdMM+onKxfDjL5A6XFLwsi7ZGX0sxDOHU4BgQDtGCNUWwW8g1O1VRjS+LC0LuoC +hL1mc6jkArF+QRAfH0/+x+P777F7RRIgA2TIcE8w4nretK9hfd3iN2IcUK+mpxRj03oB1oTu jaWHHPHBK8Vo+BccPh/xPWiH/mpiJa8VSSA4RPkAUHrxU+t1LkoZG7Q1rN/xwVAgzP/mLu2gQ MgegA+QlCO+LQIRZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 January 2016 15:34:09 Mark Brown wrote: > --- > drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------ > 1 file changed, 140 insertions(+), 121 deletions(-) Overall looks good to me, but one bug: > + > +#ifdef __64BIT > +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx, > + unsigned int reg, > + unsigned int val) > +{ > + writeq(val, ctx->regs + reg); > +} > +#endif s/__64BIT/CONFIG_64BIT/ here and in one other line. Arnd