From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755317AbdABIdJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Jan 2017 03:33:09 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:61860 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754754AbdABIdI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Jan 2017 03:33:08 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        kbuild test robot <fengguang.wu@intel.com>,
        Paul Burton <paul.burton@imgtec.com>, Jeff Dike <jdike@addtoit.com>,
        Richard Weinberger <richard@nod.at>,
        user-mode-linux-devel@lists.sourceforge.net,
        Lee Jones <lee.jones@linaro.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM
Date: Mon, 02 Jan 2017 09:32:15 +0100
Message-ID: <2271567.NkZGHHkdue@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <81455897-f6c1-79c1-7410-eff7656c1a0f@infradead.org>
References: <81455897-f6c1-79c1-7410-eff7656c1a0f@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:2WwgdzAmIlmO8aK6DNzLhgxjOEX82pIuCLQ4D5yaRPN6rMBl9gT
 D4Q0g+YqNJThEpb0q9kZ4dLfZsY0bpQT3bekBOt8bLKse5A0NkeuUAX00VDtCDy5S7WJ8lw
 3/DJsiBsdN/AFMsMLbfbhxiJcvOJWw0Bh0dEEB7L4A8ZXFe72J6qwMEVkpTh7QYvAOp9hQd
 wu8HbV6PW+RbV/5iQ5n2Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:x0YqypRrwXw=:xLQs0Qs8zRQTFi2qn5Qlh1
 W77Tt8K53GBjAQI2KcaGSjYRmkCdNrBXw10pegpJlZi793ZuIVKB0k++T/kv9pCHuucD9UyJu
 vlrLMDV4juwhdEMIS/nBRPevuKya2NZ8UiE0t9orBlkZIO0WV6rDw2NtvhvIR1M/m3vB4qcs9
 ntm85qcSCo+dHuTH2VMsVTxdafisEydAiUiuu8g2AbNypuI3znwod2mH77MqU1AHa0lTljeiH
 n5Es948YIEqdCAH1RHtgbo2+7iWKh5nAeo5g72PINL4oqzzB1j5dNNhM0IAuVlFEkhbGkSau6
 IcXTP7vT/B98iFif/XZJCIrPnFbJHxnhawTLFoLofAvW1PGPjw9Guz8RZhlMKp4zke/tmL59j
 8JAyajMzpKlYfTowp6b0m7Rj20gmPCPwyJORaj4VGFs/8ObyS8LhxTcUdPuwuyA19yf7xjxcC
 TChamzh51Qe+XnGMSVsZPrb3bFJb5UN5hhlauBkXjcOLj5HG8Nbdk+unw4vv8cAo8IVOb41RU
 6VkuRLYlY6P+Y/DX3szn0JB4GH4ZRKd8Y3PmfnhsH61K4XqNWaNDmuPztqpbrLF1yFdVeB1UU
 rft4FPtoFHeqh+ALNfSpkYiVR/B8LOSHOZIx5CPVLXO863mrmeGfazazxFtT0hCgsV9klVQaJ
 RI/EFuh0TP2ibJum4h430W4DDvKN5Y9jJzNqMDaIGD/GKT/1UNpeB/MhvSVb3RP+FuDFuibRg
 jMzsLaooGmLBMR8V
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, January 1, 2017 6:42:38 PM CET Randy Dunlap wrote:
> --- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc2/drivers/auxdisplay/Kconfig
> @@ -121,6 +121,7 @@ config CFAG12864B_RATE
>  
>  config IMG_ASCII_LCD
>         tristate "Imagination Technologies ASCII LCD Display"
> +       depends on HAS_IOMEM
>         default y if MIPS_MALTA || MIPS_SEAD3
>         select SYSCON
>         help

Maybe "depends on MIPS || COMPILE_TEST" instead?

That hides the symbol for most people that don't really want the driver
anyway, and it takes care of HAS_IOMEM for UML as well.

	Arnd