public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Constantine Shulyupin <const@makelinux.com>,
	Jean Delvare <jdelvare@suse.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: Please suggest proper format for DT properties.
Date: Tue, 22 Sep 2015 17:17:05 +0200	[thread overview]
Message-ID: <2276160.jkVDCt4RhG@wuerfel> (raw)
In-Reply-To: <56016EE9.1010302@roeck-us.net>

On Tuesday 22 September 2015 08:08:25 Guenter Roeck wrote:
> > I would strongly prefer Option 1 or 2 over option 3.
> > Between 1 and 2, I'd probably go for 1. Another option might
> > be to have a subnode per sensor:
> >
> > nct7802@2a {
> >          compatible = "nuvoton,nct7802";
> >          reg = <0x2a>;
> >       #address-cells=<1>;
> >       #size-cells=<0>;
> >
> >       sensor@1 {
> >               compatible = "nuvoton,nct7802-thermistor";
> >               further-properties;
> >       };
> >       sensor@3 {
> >               compatible = "nuvoton,nct7802-voltage";
> >               for-example-range-mv = <0 5000>;
> >       };
> > };
> >
> I personally would prefer this approach. It would also make it easier to add more
> properties. Wonder what is more appropriate, though - a compatible property or
> something like the following ?
>                 sensor-type = "xxx";
> 
> I don't have a preference, just asking.

I'm not sure here, either way would work, and we are not particularly
consistent in this regard. Maybe someone else has a stronger preference.

> Also, would the index be derived from "@1", or should there be a reg property ?

There needs to be a 'reg' property. Sorry for missing that above.

	Arnd

      reply	other threads:[~2015-09-22 15:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 22:36 Please suggest proper format for DT properties Constantine Shulyupin
2015-09-21  1:51 ` Rob Herring
2015-09-21 19:24   ` Constantine Shulyupin
2015-09-22  0:32     ` Rob Herring
2015-09-22  8:36 ` Arnd Bergmann
2015-09-22 15:08   ` Guenter Roeck
2015-09-22 15:17     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2276160.jkVDCt4RhG@wuerfel \
    --to=arnd@arndb.de \
    --cc=const@makelinux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox