From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0F3C63798 for ; Thu, 26 Nov 2020 23:34:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 414C0221F9 for ; Thu, 26 Nov 2020 23:34:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392017AbgKZXec (ORCPT ); Thu, 26 Nov 2020 18:34:32 -0500 Received: from mailoutvs34.siol.net ([185.57.226.225]:59238 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726654AbgKZXec (ORCPT ); Thu, 26 Nov 2020 18:34:32 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 441AB522A20; Fri, 27 Nov 2020 00:34:28 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 52p7gfV7aUUY; Fri, 27 Nov 2020 00:34:27 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id C5FF3522A27; Fri, 27 Nov 2020 00:34:27 +0100 (CET) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 37DA3522A20; Fri, 27 Nov 2020 00:34:26 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard@kernel.org, paul.kocialkowski@bootlin.com, Ezequiel Garcia Cc: mchehab@kernel.org, wens@csie.org, hverkuil@xs4all.nl, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Emmanuel Gil Peyrot Subject: Re: Re: [PATCH v3] media: cedrus: Add support for VP8 decoding Date: Fri, 27 Nov 2020 00:40:31 +0100 Message-ID: <2282897.HYN9I3zZbb@kista> In-Reply-To: <1496f292eadc62a3ab585a89cf9b997ce4a1d799.camel@collabora.com> References: <20201110223540.4105284-1-jernej.skrabec@siol.net> <1496f292eadc62a3ab585a89cf9b997ce4a1d799.camel@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a): > Hi Jernej, Emmanuel, > > Thanks for the patch. > > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote: > > VP8 in Cedrus shares same engine as H264. > > > > Note that it seems necessary to call bitstream parsing functions, > > to parse frame header, otherwise decoded image is garbage. This is > > contrary to what is driver supposed to do. However, values are not > > really used, so this might be acceptable. It's possible that bitstream > > parsing functions set some internal VPU state, which is later necessary > > for proper decoding. Biggest suspect is "VP8 probs update" trigger. > > > > Signed-off-by: Jernej Skrabec > > [addressed issues from reviewer] > > Signed-off-by: Emmanuel Gil Peyrot > > --- > > Changes in v3: > > - addressed comments from Ezequiel Garcia - new comments, > > using new macros from VP8 UAPI, new function for waiting > > on bit to be set > > Changes in v2: > > - rebased on top of current linux-media master branch > > > > NOTE: This now depends on following patch: > > https://patchwork.linuxtv.org/project/linux-media/patch/ 20201108202021.4187-1-linkmauve@linkmauve.fr/ > > > > The patch looks fairly good, so let's wait and see > what Hans, Paul and Maxime think about it. > > FWIW, my humble Reviewed-by: Ezequiel Garcia Thanks! > > It would be good to make sure this doesn't regress > v4l2-compliance, or cause some regression in decoding. I didn't include v4l2-compliance here, but it was in previous revisions. This revision has just cosmetics. Not sure how it could cause any regression since it's pretty standalone. > > Not really a blocker to merge this, but I'm thinking > that now that we have Fluster for conformance testing, > we could add the VP8 vectors and use them against > Cedrus and Hantro: > > https://chromium.googlesource.com/webm/vp8-test-vectors/+/refs/heads/master I tested VP8 test vectors with initial version of this decoder by hand and all videos were properly decoded as far as I can tell. But automated testing is always welcome. Best regards, Jernej > > Thanks, > Ezequiel > > > drivers/staging/media/sunxi/cedrus/Makefile | 3 +- > > drivers/staging/media/sunxi/cedrus/cedrus.c | 8 + > > drivers/staging/media/sunxi/cedrus/cedrus.h | 24 + > > .../staging/media/sunxi/cedrus/cedrus_dec.c | 5 + > > .../staging/media/sunxi/cedrus/cedrus_hw.c | 2 + > > .../staging/media/sunxi/cedrus/cedrus_regs.h | 80 ++ > > .../staging/media/sunxi/cedrus/cedrus_video.c | 9 + > > .../staging/media/sunxi/cedrus/cedrus_vp8.c | 907 ++++++++++++++++++ > > 8 files changed, 1037 insertions(+), 1 deletion(-) > > create mode 100644 drivers/staging/media/sunxi/cedrus/cedrus_vp8.c > > > >