Re: [patch 08/12] rseq: Implement time slice extension enforcement timer

K Prateek Nayak
2025-09-10T11:20:23Z

Hello Thomas,

On 9/9/2025 4:30 AM, Thomas Gleixner wrote:
> The timer is armed when an extenstion was granted right before actually

nit. s/extenstion/extension/

> returning to user mode in rseq_exit_to_user_mode_restart().

[..snip..]

> +static void rseq_cancel_slice_extension_timer(void)
> +{
> + struct slice_timer *st = this_cpu_ptr(&slice_timer);
> +
> + /*
> + * st->cookie can be safely read as preemption is disabled and the
> + * timer is CPU local. The active check can obviously race with the
> + * hrtimer interrupt, but that's better than disabling interrupts
> + * unconditionaly right away.

nit. s/unconditionaly/unconditionally/

--
Thanks and Regards,
Prateek