Re: [patch 03/12] rseq: Provide static branch for time slice extensions

Randy Dunlap
2025-09-09T04:11:19Z

On 9/8/25 8:10 PM, K Prateek Nayak wrote:
> Hello Thomas,
>
> On 9/9/2025 4:29 AM, Thomas Gleixner wrote:
>> +#ifdef CONFIG_RSEQ_SLICE_EXTENSION
>> +DEFINE_STATIC_KEY_TRUE(rseq_slice_extension_key);
>> +
>> +static int __init rseq_slice_cmdline(char *str)
>> +{
>> + bool on;
>> +
>> + if (kstrtobool(str, &on))
>> + return -EINVAL;
>> +
>> + if (!on)
>> + static_branch_disable(&rseq_slice_extension_key);
>> + return 0;
>
> I believe this should return "1" signalling that the cmdline was handled
> correctly to avoid an "Unknown kernel command line parameters" message.

Good catch. I agree.
Thanks.

>> +}
>> +__setup("rseq_slice_ext=", rseq_slice_cmdline);
>> +#endif /* CONFIG_RSEQ_SLICE_EXTENSION */
>>
>

--
~Randy