From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE08434AB1A for ; Wed, 27 Aug 2025 12:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298640; cv=none; b=J4yxOQ0OYpIfGuHv6WdnDHlQEL51FK+IyVdPtcbVF+FDfL7Kk0B8lMNUlU4R1p8ryhYPZMAFhO3BxzvQHzejHhNPvREOHYyJyYMfoTActKeWaOqe9dwX9OK7FJM0ByhcuSQlDWm2Ihq4V0/mLge/wd+Xo7xCpXbSa3CJrdKZeZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298640; c=relaxed/simple; bh=pfXL9LNkVlMzLJ8k3+XfUf3hhNWeq5ZzTbCIkPXyFVk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WUv4HGkPdeNweWNtggGP1drxKYilw44/Z8rAfqYuUN0bOtiVRF4X+RQWXOMlLMz+s0/6rflrf910T4qP3QZxCO1vA7V8oUyN+GyTBLV6A34lyw7Be0FlXfZs/vEqLEFXtkOtWKJb6yuHirah/QGb/4pBrgSilJgwrmE6QvxBryo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hLDL+MAe; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hLDL+MAe" Message-ID: <228e871e-a5c7-4570-b672-a97ac3db90c5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756298625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XXPK9rgm6hm8EGqcOxFtZdeNx/wbCo+a/fjPKpMhLw=; b=hLDL+MAeFdO6S6GwZPo1qT89iojAr28gdNsifMukqxo6jLtLXLp09wsQpXUT20NMePmJzl +hexT091mG1JyUQ1gBSNCqhuFLf6zoRLv5jpZnmAONL2ZIZL/ysE7sS7x1tgJDZG900Nyw /xW7WAPkq+XrMuaOv5g9JWlqYu3+DaU= Date: Wed, 27 Aug 2025 13:43:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v4 2/2] ethernet: eswin: Add eic7700 ethernet driver To: weishangjuan@eswincomputing.com, devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, yong.liang.choong@linux.intel.com, vladimir.oltean@nxp.com, rmk+kernel@armlinux.org.uk, faizal.abdul.rahim@linux.intel.com, prabhakar.mahadev-lad.rj@bp.renesas.com, inochiama@gmail.com, jan.petrous@oss.nxp.com, jszhang@kernel.org, p.zabel@pengutronix.de, boon.khai.ng@altera.com, 0x1207@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, lizhi2@eswincomputing.com References: <20250827081135.2243-1-weishangjuan@eswincomputing.com> <20250827081418.2347-1-weishangjuan@eswincomputing.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250827081418.2347-1-weishangjuan@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 27/08/2025 09:14, weishangjuan@eswincomputing.com wrote: > From: Shangjuan Wei > > Add Ethernet controller support for Eswin's eic7700 SoC. The driver > provides management and control of Ethernet signals for the eiC7700 > series chips. > > Signed-off-by: Zhi Li > Signed-off-by: Shangjuan Wei > --- [...] > +/** > + * eic7700_apply_delay - Update TX or RX delay bits in delay parameter value. > + * @delay_ps: Delay in picoseconds (capped at 12.7ns). > + * @reg: Pointer to register value to modify. > + * @is_rx: True for RX delay (bits 30:24), false for TX delay (bits 14:8). > + * > + * Converts delay to 0.1ns units, caps at 0x7F, and sets appropriate bits. > + * Only RX or TX bits are updated; other bits remain unchanged. > + */ > +static inline void eic7700_apply_delay(u32 delay_ps, u32 *reg, bool is_rx) inlining functions in .c files is discouraged in netdev, let the compiler decide inlining > +{ > + if (!reg) > + return; please, avoid defensive programming. with this check you also mixing code and variables.. > + > + u32 val = min(delay_ps / 100, EIC7700_MAX_DELAY_UNIT); > +> + if (is_rx) { > + *reg &= ~EIC7700_ETH_RX_ADJ_DELAY; > + *reg |= (val << 24) & EIC7700_ETH_RX_ADJ_DELAY; > + } else { > + *reg &= ~EIC7700_ETH_TX_ADJ_DELAY; > + *reg |= (val << 8) & EIC7700_ETH_TX_ADJ_DELAY; these 2 assignments should be converted to FIELD_PREP() > + } > +} > +