From: Mikael Pettersson <mikpelinux@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mikpelinux@gmail.com, sam@ravnborg.org, matorola@gmail.com,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: strace-4.18 test suite oopses sparc64 4.12 and 4.13-rc kernels
Date: Fri, 4 Aug 2017 10:02:25 +0200 [thread overview]
Message-ID: <22916.10769.43405.588851@gargle.gargle.HOWL> (raw)
In-Reply-To: <20170803.145748.1255019771865320896.davem@davemloft.net>
David Miller writes:
> From: Mikael Pettersson <mikpelinux@gmail.com>
> Date: Thu, 3 Aug 2017 22:02:57 +0200
>
> > With that in place the kernel booted fine.
> > When I then ran the `poll' strace test binary, the OOPS was replaced by:
> >
> > [ 140.589913] _copy_from_user(fff000123c8dfa7c, (null), 240) res 240
> > [ 140.753162] _copy_from_user(fff000123c8dfa7c, 00000000f7e4a000, 8) res 8
> > [ 140.824155] _copy_from_user(fff000123c8dfa7c, 00000000f7e49ff8, 16) res 18442240552407530112
> >
> > That last `res' doesn't look good.
>
> Please test this patch:
>
> diff --git a/arch/sparc/lib/U3memcpy.S b/arch/sparc/lib/U3memcpy.S
> index 54f9870..5a8cb37 100644
> --- a/arch/sparc/lib/U3memcpy.S
> +++ b/arch/sparc/lib/U3memcpy.S
> @@ -145,13 +145,13 @@ ENDPROC(U3_retl_o2_plus_GS_plus_0x08)
> ENTRY(U3_retl_o2_and_7_plus_GS)
> and %o2, 7, %o2
> retl
> - add %o2, GLOBAL_SPARE, %o2
> + add %o2, GLOBAL_SPARE, %o0
> ENDPROC(U3_retl_o2_and_7_plus_GS)
> ENTRY(U3_retl_o2_and_7_plus_GS_plus_8)
> add GLOBAL_SPARE, 8, GLOBAL_SPARE
> and %o2, 7, %o2
> retl
> - add %o2, GLOBAL_SPARE, %o2
> + add %o2, GLOBAL_SPARE, %o0
> ENDPROC(U3_retl_o2_and_7_plus_GS_plus_8)
> #endif
>
Backing out my debugging patch and adding this one instead
gave me a working kernel that doesn't OOPS. Thanks.
Tested-by: Mikael Pettersson <mikpelinux@gmail.com>
next prev parent reply other threads:[~2017-08-04 8:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 19:45 strace-4.18 test suite oopses sparc64 4.12 and 4.13-rc kernels Mikael Pettersson
2017-07-28 5:10 ` David Miller
2017-07-28 8:45 ` Mikael Pettersson
2017-07-28 18:27 ` David Miller
2017-07-28 18:37 ` David Miller
2017-07-29 10:52 ` Anatoly Pugachev
2017-07-29 12:02 ` Mikael Pettersson
2017-07-31 17:14 ` Mikael Pettersson
2017-07-31 21:48 ` Anatoly Pugachev
2017-07-31 21:51 ` David Miller
2017-07-31 22:01 ` Anatoly Pugachev
2017-07-31 22:06 ` David Miller
2017-08-01 7:29 ` Mikael Pettersson
2017-08-01 20:58 ` Sam Ravnborg
2017-08-02 21:36 ` Sam Ravnborg
2017-08-02 23:27 ` David Miller
2017-08-03 20:02 ` Mikael Pettersson
2017-08-03 21:57 ` David Miller
2017-08-04 5:44 ` Sam Ravnborg
2017-08-04 8:02 ` Mikael Pettersson [this message]
2017-08-04 16:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22916.10769.43405.588851@gargle.gargle.HOWL \
--to=mikpelinux@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matorola@gmail.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).