From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945483AbcJaSYV (ORCPT ); Mon, 31 Oct 2016 14:24:21 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51743 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934098AbcJaSYS (ORCPT ); Mon, 31 Oct 2016 14:24:18 -0400 X-AuditID: cbfee61b-f793d6d000005a2a-cf-581789f8c885 From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , Kevin Hilman , "Nori, Sekhar" Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Mon, 31 Oct 2016 19:14:13 +0100 Message-id: <2291876.8LAt3RcuXX@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20161031154622.GB1041@n2100.armlinux.org.uk> References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <20161031154622.GB1041@n2100.armlinux.org.uk> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t9jQd0fneIRBtc7eC3+TjrGbjHpyXtm i5/tW5gsNj2+xmpxbMcjJovLu+awWRyaupfRYn/vBiaLU9c/szlwely+dpHZ4/evSYwe72+0 snvsnHWX3WPzknqPKyeaWD2O39jO5PF5k1wAR5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWS Ql5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMpr+mhbsEKr4dGkLSwPjKr4uRk4O CQETienrbjBB2GISF+6tZ+ti5OIQEpjFKDHv7iUmCOcro8TU0y9ZQKrYBKwkJravYgSxRYC6 jx38wgJSxCwwl0ni+fLD7F2MHBzCAp4SG37pgNSwCKhKrJx3kRXE5hXQlJi6qoUNxBYV8JLY sq8dbDMn0MwTe84zQyw7wyjRs/c2G0SDoMSPyffAFjMLyEvs2z+VFcLWkli/8zjTBEagOxHK ZiEpm4WkbAEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Kh8Jr2D8fAu90OMAhyM Sjy8DVniEUKsiWXFlbmHGCU4mJVEeB93AIV4UxIrq1KL8uOLSnNSiw8xmgJ9OJFZSjQ5H5gw 8kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRqYIwOc31zX2ulfPrH rUsmJV6oDJ99i6O/mfX+MdvOiKofrV6tu2YerMnY//Lu2/K/+x0XvDjUE9qpPWF5+Pzkgx23 Zt9dseEV29pej6ZFNbc2ff6aJ7U8ttX6nXM6y2//TLPJ29pFbeIWbD//MN/0b+rJ9ymv8nay qf7ZPL9dtjvrSl7S5YkyArZKLMUZiYZazEXFiQCOMClC4AIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, October 31, 2016 03:46:22 PM Russell King - ARM Linux wrote: > On Wed, Oct 26, 2016 at 07:01:12PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Wednesday, July 13, 2016 04:37:31 PM Arnd Bergmann wrote: > > > On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > > > > > On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote: > > > > > On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > > > This patch disables deprecated IDE subsystem in assabet_defconfig > > > > > > (no IDE host drivers are selected in this config so there is no > > > > > > valid reason to enable IDE subsystem itself). > > > > > > > > > > > > Cc: Dmitry Eremin-Solenikov > > > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > > > > > > > > > I think the series makes a lot of sense. I have checked your assertions > > > > > in the changelogs and found no flaws in your logic, so I think we should > > > > > take them all through arm-soc unless there are other concerns. > > > > > > > > Thank you. > > > > > > > > Should I resend everything or just patches that were not reposted yet > > > > (the ones that were marked as RFT initially and got no feedback)? > > > > > > I'd be fine with just getting a pull request with all the patches that > > > had no negative feedback and that were not already applied (if any). > > > > Here it is (sorry for taking so long). > > I've just been digging in the dmesg logs from when I was using the > Assabet+Neponset as my firewall, and it was having to use the IDE > ide-cs driver rather than the pata pcmcia driver. > > I don't recall whether the pata pcmcia driver was a problem or not, > as the PCMCIA interface can't cope with _any_ 32-bit accesses. I > think PATA tries to use the "highest" possible access size by > default... It doesn't actually - it defaults to 16-bits for PIO data access and you must explicitly enable 32-bits using ATA_PFLAG_PIO32 port flag (pata_pcmcia doesn't set it so it should be okay). Also taskfile registers are accessed using 8-bits access by default transport functions (which are used by pata_pcmcia). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics