* [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
@ 2020-11-16 1:09 Xiongfeng Wang
2020-11-17 17:47 ` Jernej Škrabec
0 siblings, 1 reply; 3+ messages in thread
From: Xiongfeng Wang @ 2020-11-16 1:09 UTC (permalink / raw)
To: airlied, daniel, jernej.skrabec
Cc: dri-devel, linux-kernel, linux-arm-kernel, wangxiongfeng2,
chenzhou10
Fix to return a negative error code from the error handling case instead
of 0 in function sun8i_dw_hdmi_bind().
Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index d4c0804..92add2c 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
phy_node = of_parse_phandle(dev->of_node, "phys", 0);
if (!phy_node) {
dev_err(dev, "Can't found PHY phandle\n");
+ ret = -EINVAL;
goto err_disable_clk_tmds;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
2020-11-16 1:09 [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() Xiongfeng Wang
@ 2020-11-17 17:47 ` Jernej Škrabec
2020-11-18 1:04 ` Xiongfeng Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jernej Škrabec @ 2020-11-17 17:47 UTC (permalink / raw)
To: airlied, daniel, Xiongfeng Wang
Cc: dri-devel, linux-kernel, linux-arm-kernel, wangxiongfeng2,
chenzhou10
Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang
napisal(a):
> Fix to return a negative error code from the error handling case instead
> of 0 in function sun8i_dw_hdmi_bind().
>
> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
Applied to drm-misc-fixes, thanks!
In future, please CC all people given by get_maintainer.pl script. In this
case you missed Maxime Ripard and Chen-Yu Tsai.
Best regards,
Jernej
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
2020-11-17 17:47 ` Jernej Škrabec
@ 2020-11-18 1:04 ` Xiongfeng Wang
0 siblings, 0 replies; 3+ messages in thread
From: Xiongfeng Wang @ 2020-11-18 1:04 UTC (permalink / raw)
To: Jernej Škrabec, airlied, daniel
Cc: dri-devel, linux-kernel, linux-arm-kernel, chenzhou10
On 2020/11/18 1:47, Jernej Škrabec wrote:
> Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang
> napisal(a):
>> Fix to return a negative error code from the error handling case instead
>> of 0 in function sun8i_dw_hdmi_bind().
>>
>> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Applied to drm-misc-fixes, thanks!
>
> In future, please CC all people given by get_maintainer.pl script. In this
> case you missed Maxime Ripard and Chen-Yu Tsai.
Sure, thanks for reminding me.
Thanks,
Xiongfeng
>
> Best regards,
> Jernej
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-18 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 1:09 [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() Xiongfeng Wang
2020-11-17 17:47 ` Jernej Škrabec
2020-11-18 1:04 ` Xiongfeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox