From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936094AbcIPQsS (ORCPT ); Fri, 16 Sep 2016 12:48:18 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38154 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754848AbcIPQsM (ORCPT ); Fri, 16 Sep 2016 12:48:12 -0400 Subject: Re: [PATCH 2/2] phy: msm8996-pcie-phy: Add support to msm8996 pcie phy To: Archit Taneja , Kishon Vijay Abraham I References: <1473245733-17260-1-git-send-email-srinivas.kandagatla@linaro.org> <1473245733-17260-3-git-send-email-srinivas.kandagatla@linaro.org> <57D82403.9080004@codeaurora.org> Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Srinivas Kandagatla Message-ID: <2296a3a9-164a-c46c-ef98-2bd2d97039c8@linaro.org> Date: Fri, 16 Sep 2016 17:48:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57D82403.9080004@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/16 17:06, Archit Taneja wrote: > > > On 9/7/2016 4:25 PM, Srinivas Kandagatla wrote: >> This patch adds support to msm8996 pcie phy which supports 3 ports, >> Port A, Port B and Port C. >> >> Each port is independent and connected to a pcie host controller, >> there is >> also a common block which is shared across all the 3 ports. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-qcom-msm8996-pcie.c | 492 >> ++++++++++++++++++++++++++++++++++++ >> +#define PCIE_LANE_PCS_BASE 0x1400 > > I've seen the reg offsets of another SoC using the same > IP, but the above offsets aren't the same relative to the > phy base. We might want to create more reg properties in > DT to accommodate register maps on other SoCs. Yep, I got some more info on this from Vivek and It looks like this IP has been reused on other Host controllers and SOCs. So plan is to write a common driver for all of them. Thanks, srini