From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756833AbdJPS66 (ORCPT ); Mon, 16 Oct 2017 14:58:58 -0400 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbdJPS65 (ORCPT ); Mon, 16 Oct 2017 14:58:57 -0400 From: Richard Weinberger To: Daniel Borkmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@kernel.org Subject: Re: [PATCH 2/3] bpf: Remove dead variable Date: Mon, 16 Oct 2017 20:59:33 +0200 Message-ID: <2297422.9nBBslcvMo@blindfold> In-Reply-To: <59E5006C.4090303@iogearbox.net> References: <20171016181856.12497-1-richard@nod.at> <20171016181856.12497-2-richard@nod.at> <59E5006C.4090303@iogearbox.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 16. Oktober 2017, 20:54:36 CEST schrieb Daniel Borkmann: > On 10/16/2017 08:18 PM, Richard Weinberger wrote: > > task is never used in bpf_get_current_uid_gid(), kill it. > > > > Signed-off-by: Richard Weinberger > > --- > > > > kernel/bpf/helpers.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > > index e8845adcd15e..511c9d522cfc 100644 > > --- a/kernel/bpf/helpers.c > > +++ b/kernel/bpf/helpers.c > > @@ -131,7 +131,6 @@ const struct bpf_func_proto > > bpf_get_current_pid_tgid_proto = {> > > BPF_CALL_0(bpf_get_current_uid_gid) > > { > > > > - struct task_struct *task = current; > > > > kuid_t uid; > > kgid_t gid; > > Needs to be squashed into patch 1/3? I can squash it into 1/3, I kept it that way because even without 1/3 this variable is unused. Thanks, //richard