From: Amit Shah <amit@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux.dev
Subject: Re: [PATCH] virtio_console: fix misc probe bugs
Date: Tue, 17 Sep 2024 10:39:55 +0200 [thread overview]
Message-ID: <22b91bc1410bf2a9b54b69a56075d368bf3e06d1.camel@kernel.org> (raw)
In-Reply-To: <ad982e975a6160ad110c623c016041311ca15b4f.1726511547.git.mst@redhat.com>
On Mon, 2024-09-16 at 14:32 -0400, Michael S. Tsirkin wrote:
> This fixes the following issue discovered by code review:
>
> after vqs have been created, a buggy device can send an interrupt.
>
> A control vq callback will then try to schedule control_work which
> has
> not been initialized yet. Similarly for config interrupt. Further,
> in
> and out vq callbacks invoke find_port_by_vq which attempts to take
> ports_lock which also has not been initialized.
>
> To fix, init all locks and work before creating vqs.
>
> Fixes: 17634ba25544 ("virtio: console: Add a new MULTIPORT feature,
> support for generic ports")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Amit Shah <amit@kernel.org>
prev parent reply other threads:[~2024-09-17 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 18:32 [PATCH] virtio_console: fix misc probe bugs Michael S. Tsirkin
2024-09-16 18:50 ` Greg Kroah-Hartman
2024-09-17 8:39 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b91bc1410bf2a9b54b69a56075d368bf3e06d1.camel@kernel.org \
--to=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox