From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A27660250 for ; Wed, 6 Mar 2024 17:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709745677; cv=none; b=We4xxtjrnyYfcxcGU4QC+jLR8LZZHVv6moUoLStuABE+eOSNIRXI4+7oI+EEHMyxm1U9pXg4KVHAlbzs9/7AfO+bHLQ6/pT6dEjtQWV4vX7jVdUwlgKMh9UNpnxFR9fMdFoZy4mqQRKSE6TJXnN9CSJUK6JSOikYkOAYStzvqs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709745677; c=relaxed/simple; bh=49Up81ZbgJmdwa8GIlUFaFyVt+xRUPlfXB0cFDd2aWQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IKSSBheXkTppIj+tZ1yOBuDZsE+h0zeqsF3/Ep0oCmJVYSt9TV8IdSthBwml8KwJbntwj7n9MNoTl/AINsB/pHhuBFbbTbp2AT7L2bcWNan9sqG3Sbgz/Q7Xc7GO4jYFw3+3ctbruDy0Ov8fGydLkILeSR9h/urW7rlKSRrJy8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Rvzs4PDb; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Rvzs4PDb" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a3ddc13bbb3so204419866b.0 for ; Wed, 06 Mar 2024 09:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1709745674; x=1710350474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6b7AEWTHQqCnLEs2wSNzarO+p6XqtsGbbdwNY0/h8HI=; b=Rvzs4PDbtj0uEShGTE53Zz5GzYS49MmtWlrSCuDcS3S2CJbozuKGlx9T7cwn7VxZsq hD1aa7eDiMkVKOmVZnaG5m8b8ZD3YnkhGNbTIuo5nSeswrSK6mPIuJpPr3rhB9uU9XdC AjqzSFiU7OUvSL/3oPjbxheXtzTk5SDiek/CexVRmlmkr524jRjQ0VC6Hvj6VynEjjFe 5apTAeNm7FrCwNucHGNWvpvXl9JCMesDkXWRQzClD56T9SCoFwyh23EFrIpuDDKULdJI 45yjIm2jVMCoz9zgvSaGZQQgj8wDCUSnRF/8o7tlN4vdLFbUdfKk29h0iqTu87JV92Zb 7yrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709745674; x=1710350474; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6b7AEWTHQqCnLEs2wSNzarO+p6XqtsGbbdwNY0/h8HI=; b=V0zHvbO8E7yesC2I0QnPWOQbcCly1nwpNFDZASgTVAyVqqn8UCq+Ih633idC+Mynm0 7ocKIRnkOdydocMfzKc4lLwvi1aXliy6WF50jd2NvevYd1JMywH2a0wk2CLjHnHQhd5k ihkxEwA6h1BqN0Ik21GluizU0YTQJY7OUpLKoxTpTfnjV4X0fpnbJ0LHmieWRZCuqz0E cVMzppPxQMumF6kLaASdZkjPSO64Rq6UfPVOpS2O2K2QomP2HpXFUTirBfVNDaw9/0Hs tiS26E4a5/joh/ZdxHqrIPS1J4cCG4no7xfXUI30WInvHs+zwJ2uy7guLMYgGIXHIuP7 /rKw== X-Forwarded-Encrypted: i=1; AJvYcCVyIaLtGr8n8ToXAEMfmkfZwxwQG5Sfcgefk9vT5sSCte2fzFvDu+xp2lrqoGMXRjaoEXff00z7Mk4C5U5TVz2fH8y46J4oh9WXVOz5 X-Gm-Message-State: AOJu0YwVsYSU6sGWtA/mGg1ysht0UY3yZMG2nqhoX/XJFKGk8LJ4aLs8 tu3aEAwB0WpHNfkssOYBF4OkXgDI7W4hl3j81e8cpI5lndkHbhOxP3CS57Ufi8Y= X-Google-Smtp-Source: AGHT+IH8FAZXjKs24NTijeBCoQufQg0eKtaUfx+QDqRTEpbcRSgiDnextqhBzmGLzu/d5moJUDFSxA== X-Received: by 2002:a17:906:b250:b0:a45:becb:6e3c with SMTP id ce16-20020a170906b25000b00a45becb6e3cmr1678840ejb.35.1709745673791; Wed, 06 Mar 2024 09:21:13 -0800 (PST) Received: from ?IPV6:2001:a61:1366:6801:b2db:904d:e0b0:46ec? ([2001:a61:1366:6801:b2db:904d:e0b0:46ec]) by smtp.gmail.com with ESMTPSA id fw17-20020a170906c95100b00a4576dd5a8csm2978506ejb.201.2024.03.06.09.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 09:21:13 -0800 (PST) Message-ID: <22bf5a02-7bb7-438e-98ce-25e3bf805b2c@suse.com> Date: Wed, 6 Mar 2024 18:21:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] net: usbnet: Leverage core stats allocator To: Breno Leitao , Oliver Neukum , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, dsahern@kernel.org, "open list:USB NETWORKING DRIVERS" References: <20240306142643.2429409-1-leitao@debian.org> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20240306142643.2429409-1-leitao@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.03.24 15:26, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the usbnet driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Acked-by: Oliver Neukum