From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974B6319615 for ; Wed, 17 Sep 2025 13:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116342; cv=none; b=ZYEH2MBh/7B4L6A9CHjwhmUUxg89M01IMzQDYdIQluMiHvuT9l7Ix+uMrIwyaE6PM2g4DnegMILtiY6832vtnSNm4YTF84SD87fPr+iQBO7fGwrM99hqpV45l6DfH305YBPbk0IfeiQkDz91+WkQPFU59FSV6Tda0A3aLQFLemY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116342; c=relaxed/simple; bh=1a1RGyOEU++H/the0LpqR7ztI6UvvUkE+gX4LxX6WQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPCMNryGikTRbAnZAlOPBO8tz4KlMTqN2RPsu/fXY2ddBA1o01Yr/RVtkn7Rqg3wvHRQPpGGaC0UlMOY7qRSWhHFgQJzgRF9CDh4M4b6BP0MC26GodcaTK8fs5CvkWfPTltcVWfiC2T+nB2vCsGAILKvQETTIeCvQVs1lMkWA7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P1CGLuQi; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P1CGLuQi" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3ec4d6ba0c7so1703732f8f.1 for ; Wed, 17 Sep 2025 06:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758116339; x=1758721139; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gBjPagXwVXjct44W+AEh9yq9e3RGS/ToZPXdGSZz0Ms=; b=P1CGLuQiSDvsfaWoo3keY/7ekbrh8SzFah2C12INeQgQFAqiLE5FWsJjAzysvye5dK OUYiIss1NKXJkdyCYo4wTLB04pDj6UmGjNR8k8tt1kgLBKCqfbgENQK+BOkRM1G8bArG a7hxk/7xcfvqeHfcTmd4egX9pXG+5aVerAaxEN4PUk30sml0vhfl/dNnFnKS/MyiQp0Q 47fyR5W388kwM8Bh2+7r8AjHWfLNymN3yj4K13Dr9wp0boPcIgIMn8VBa9SZJmZZDldW WnTfsHEVBuxK3SpXJLjtKHLQnC38dPyoEuAbpAFQhwT5Ij3kc+2GXmi7uRHCLXSodTNv 7Orw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758116339; x=1758721139; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gBjPagXwVXjct44W+AEh9yq9e3RGS/ToZPXdGSZz0Ms=; b=Y9A6UCscq1l8+61aPdlgbLJSEYBwtokJjCWe3lq2y7J5HZ/KtmgWNaP4KKh1MejJA8 H0+f5Ijd3bbC1g2IsMxdg8BUKwAQz9P1ErJCK3jaVL1n60Sd+VVw7s3j3y0p5pjjAnYr 314PCgmCaW+YKDbIHZUZ7WKCfZeNXAL1ZCNa1QtQijNWboryS8lcuSTxK8kpx3kK/1dU 3DpTT6MX9yzo0TAX9MdZaadnLYF5pF7lEcqw55h8NkgW0KWk38mkg6Q9AdgZyaKy9ljW nzI/EcOMSXDjrx9PG+ouRn2ImusijKLdY3XIqql5Etkr0rB/sKiD+hKgHciBKEFNVqI+ a5DQ== X-Forwarded-Encrypted: i=1; AJvYcCUh7V/W9/6B3y80QXaB12RlTNe+M4p30ZFmtM5dLUuawxY0/lWHi4OJ9xThkWm9Ty2NUqqpBg71Yl48yGk=@vger.kernel.org X-Gm-Message-State: AOJu0YyirW5agoaq0PG7WGE54V+Zwg3f0AU+os6bZ0MXMEYhQcRxZt6c jV5R6FXRPqs7YGeWeICxhZXOOYZeEbc6bsF6x1iN6kxzOpQfSmxA4ehl X-Gm-Gg: ASbGnct4eKIo+yyvTpO5Mn4Npz/KUuaUeDw+1SjBv6sjqH7dVTjSN7NRxykGvDxYQN7 AXG+iyliiXZvroniO9fSgAX5m9yGVKWmQaEOGpti6mK7282lGYuvpZVEV0NNWR44jIhSaWfG8Nl 1A+LdM4hT77Du4OMaIeXa5RePm86XCkarA048Rg7pw3OkAzHDpJ172sxs+3Erwdpk0W3Tb7732y AHGIkuRkBhLc3qJmdwJIBUHyiwgNr653983dcJlT7UJrQu7Wd3F+NBXu6UC2EBKdmqPElbIrvgS g+zn8o3+FmD9bqah4u1YxbYxxxAQlTfHGnMg6g4O8bQbbZ0SZ8EYakvnZGblkp0cBPNaQJxwUoK DrWkrBVc+THtac82uIBH04cEdHAio7+kPJVquQSWKzV/lrjNZQeGjCA== X-Google-Smtp-Source: AGHT+IH7qzQEHfiS4gG1DZC2jmRra+O7WyeZowBozu0NNUNL9xvNAPAEdUNJh9cvbkkud3VZ5XgSwQ== X-Received: by 2002:a5d:64c8:0:b0:3ea:e0fd:290b with SMTP id ffacd0b85a97d-3ecdfa0d2f1mr2162241f8f.40.1758116338491; Wed, 17 Sep 2025 06:38:58 -0700 (PDT) Received: from [10.80.3.86] ([72.25.96.18]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46137a252fasm37570245e9.7.2025.09.17.06.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 06:38:58 -0700 (PDT) Message-ID: <22c4fa32-43dc-4c92-87d3-88e2ce3dfd00@gmail.com> Date: Wed, 17 Sep 2025 16:38:56 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net V2 10/11] net/mlx5e: Update and set Xon/Xoff upon port speed set To: Daniel Zahka , Jakub Kicinski Cc: Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Tariq Toukan , Leon Romanovsky , Saeed Mahameed , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , linux-rdma@vger.kernel.org, Alexei Lazar , Mark Bloch References: <20250825143435.598584-1-mbloch@nvidia.com> <20250825143435.598584-11-mbloch@nvidia.com> <20250910170011.70528106@kernel.org> <20250911064732.2234b9fb@kernel.org> <20250911073630.14cd6764@kernel.org> <1407e41e-2750-4594-adaf-77f8d9f8ccf7@gmail.com> <71ce45fc-5214-4d40-b8c4-abab1d44314a@gmail.com> Content-Language: en-US From: Tariq Toukan In-Reply-To: <71ce45fc-5214-4d40-b8c4-abab1d44314a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/09/2025 16:00, Daniel Zahka wrote: > > > On 9/17/25 6:39 AM, Tariq Toukan wrote: >> >> >> On 15/09/2025 10:38, Tariq Toukan wrote: >>> >>> >>> On 11/09/2025 17:36, Jakub Kicinski wrote: >>>> On Thu, 11 Sep 2025 17:25:22 +0300 Mark Bloch wrote: >>>>> On 11/09/2025 16:47, Jakub Kicinski wrote: >>>>>> On Wed, 10 Sep 2025 17:00:11 -0700 Jakub Kicinski wrote: >>>>>>> Hi, this is breaking dual host CX7 w/ 28.45.1300 (but I think most >>>>>>> older FW versions, too). Looks like the host is not receiving any >>>>>>> mcast (ping within a subnet doesn't work because the host receives >>>>>>> no ndisc), and most traffic slows down to a trickle. >>>>>>> Lost of rx_prio0_buf_discard increments. >>>>>>> >>>>>>> Please TAL ASAP, this change went to LTS last week. >>>>>> >>>>>> Any news on this? I heard that it also breaks DCB/QoS configuration >>>>>> on 6.12.45 LTS. >>>>> >>>>> We are looking into this, once we have anything I'll update. >>>>> Just to make sure, reverting this is one commit solves the >>>>> issue you are seeing? >>>> >>>> It did for me, but Daniel (who is working on the PSP series) >>>> mentioned that he had reverted all three to get net-next working: >>>> >>>>    net/mlx5e: Set local Xoff after FW update >>>>    net/mlx5e: Update and set Xon/Xoff upon port speed set >>>>    net/mlx5e: Update and set Xon/Xoff upon MTU set >>>> >>> >>> Hi Jakub, >>> >>> Thanks for reporting. >>> We're investigating and will update soon. >>> >>> Regards, >>> Tariq >>> >> >> Hi, >> >> We prefer reverting the single patch [1] for now. We'll submit a fixed >> version later. >> >> Regarding the other two patches [2], initial testing showed no issues. >> Can you/Daniel share more info? What issues you see, and the repro steps. >> >> Thanks, >> Tariq >> >> [1] >> net/mlx5e: Update and set Xon/Xoff upon port speed set >> >> [2] >> net/mlx5e: Set local Xoff after FW update >> net/mlx5e: Update and set Xon/Xoff upon MTU set >> > > Hello Tariq, > > My notes for the situation were that I was running a vanilla net-next > kernel on a dual host, CX7 system, with the 28.45.1300 FW at commit: > > deb105f49879 net: phy: marvell: Fix 88e1510 downshift counter errata > > and I was having the issues that Jakub described. No ping working in a > subnet. Extremely slow bandwidth on a large transfer. My notes say that > reverting just [1] (from your message) did not fix the problem, but then > reverting [2] and [3] restored normal behavior. > > However, I did attempt to reproduce again on the same system this > morning, and now I'm seeing that reverting just [1] is sufficient to fix > the issues. I see. For now, I'll submit a revert only for [1]. Let us know of any related issue you still hit after the revert. Thanks.