From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED29426FD9B for ; Thu, 7 May 2026 04:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778129086; cv=none; b=EpSi3zBp/vSMrgfj1gsvhTSOKRy7xOrIMOGIiNVuExFd8G0tgM03lggB3p2i3EYMSQBulPlCCS5L/GkrmzYmkS+ekqR8v1h8aHi49LRLFulALDd+TxjR9yHVkvhArxc2Y3LcU9Q+bMahrTTsaQWcz+l7oANCyJa/G+OObcWgyd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778129086; c=relaxed/simple; bh=tnhIOCL+xNnplydUI/qF2P/AgYmmBKT1oW2qU1iTQGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iD773ZOeCA49lYbZOIasE36VhNTynsePSWoHl64q5Z0XpRR+qmnpnsnm+iFDDEdMTB29Qu155JztV8TXnI9aducNhWXl5+TGo8S63WxDRSiOpJk/mYzro3+lG2FeaNMi8i++NKDcOPairl3klBw9rUhG9uK8DgcFpmNMq5pOi9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O+d9GyK9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jyVLCKn0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O+d9GyK9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jyVLCKn0" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6472LEGj3463995 for ; Thu, 7 May 2026 04:44:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EM+AHwi/TQ0ZXjnKKM7fIcSXzsuI4UJ/Vxly4Jl/dgc=; b=O+d9GyK9oMXaW4Fc 6GoL6SBQeGXriYijtIB9xc2GX6fFF5aMmhcAsv4zBSUrCKafFmu2JKdFyewFX7MY kV2f7ajwpf0OHJ2yGc38GIeHvkwcDRRNzYXPMUuqQODUiNu2GSCaIg26yNIWhTB+ 1EZ1D8At519MeoFhikB9mI4mja8fadYXhdxJLhHkqKgqJ1OHVKngKnvcHKUUX0EH HgkuBkNEWYosLn+CXoKlLCGIgcpPQzXWg/RLuCacdIQ1Unp3+zWTPsJNgkMjuUhZ Vl4mrSUE9W6fCFwkW0/m+f3APHe2mTfLGOlCudtguCvICH+bQrbmBwmmuwasjcT0 nAkIhQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hvn0cdc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 04:44:43 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba15e384c7so3401615ad.3 for ; Wed, 06 May 2026 21:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778129083; x=1778733883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EM+AHwi/TQ0ZXjnKKM7fIcSXzsuI4UJ/Vxly4Jl/dgc=; b=jyVLCKn0EDykyCLXPUcE9RZSJjJj7SPLgk7iYUo8XCvtFI5/Dnk2uNFZ5Ge/vrso44 /T2lQ8rGJYo4Cu7eTVSg+HcirLx3hHqjU/7HQcTQQJRobjFjaH2emFZiTU157JZkIEAA yVd0h+oDDS2fhf3IHwbVWnWPBmxspPyLlhcjfTxRWX6522UGZtY4PGoF2QFIsJFN2BXp /4L82ojsld4mpKL/0JuPyqP8MtFy79J4QLHzvjb7uK9WDteHMb1oJchwooSCbxRIUBbq 4w6yZI9Pkki03M0wFVYGRy+iwYTLKknnXyB40nR0YyT1pido8l/1tKFxt40+M7DWbXg1 WoVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778129083; x=1778733883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EM+AHwi/TQ0ZXjnKKM7fIcSXzsuI4UJ/Vxly4Jl/dgc=; b=KHj1pRZBqRjenERj8yCMYJQHSv+bUjFx8eEpGQH6/kGsWxT+UKBCODVyq3zaFQa3RY MmadKx204HseYwyObwGTrxX7YC3PEnsv6l0qmHTJeYY6nBu73lOFtv96ROnzCtt3m3xv CwA/za95MItcOFzZw54yXDQJv9GqSN2SNA/Z3rikyg1gMsnzRleZyaGxLc/sl+fYni3U 2Y3b8ONV/H4uHBtPZxFzCmz5NHu/9xQa7gAIathDe6dvvxpN6yZspQKmWfjfeayqT0Q/ k8KvJak8m4lf9Xh796FWE4RYvVnsGIg1tBIXiVXU7FWLTwRHecAa8vl6rWfs44xp2GEv /6ww== X-Forwarded-Encrypted: i=1; AFNElJ8ZGSw0b86fqdMtNHT7mV8P4Ot9uk2ODjcMvMViKLZ9okhNjcuxJqXblV6g/IFZ6RbpjetYYAUDZ25ufA0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3iiBYpNladnSvdmssovOX81FKhdxj1xE4yetag5z4Axgp+/RK HUgn3BSO1dYF2RgJy8NwXcWWYOcPDRhG7jNjWGcaGrY8LcHwOjkjyGi/wRXkRQCQeYjEN6nb/L5 DC9s5/hgNeVN0lkS0eElOnFW+k2oeb/nFVC/tfz3eAZFvTcLv3bWIkJGFGbANqrh/AdY= X-Gm-Gg: AeBDietfnuIoMTpZQB38ICQeISd310lEpFmsgT4OM6WCRxIAniCa8kDnNRA0k8OCmMC kPRiBJisz1sax+k1do0Rxzlq6cpXoSJkOUq0PkaWp+xITQTrNEsnUTXgEx8rUSYAArnmgOuLXm5 VwqbE9UiPVW4P1rkVRmbLiF0gjo2TNP9AQDdxNY857P52oANrmDnOs9WuJyRpG3E973aAHAl7AE lMFCD3pYEAwk+7NJnF0mDachkuR09DD7hGYJQNrF0aZbwlXqMwQ4QqZv9zS94DreA5X67ltrVZM zSi9TPc4mHLnL37bM+NSpPMaWuSo/4RjIIJ4T1wQhzzsvi6//clBe/Gx4U+WbVps7TOrovwT9Mo XFS/FtPaFCnbNV9W9m0Lya9xwhUzhYP6CQQwkWpT0y1/CMX1Z+CcM9rkr+OvIocdaxVPTt1lNrh xh06Wrq1gV6gRg483qwxPjfehbPL0= X-Received: by 2002:a17:903:3bd0:b0:2b0:7d3d:756a with SMTP id d9443c01a7336-2ba794c05aemr77557345ad.35.1778129083205; Wed, 06 May 2026 21:44:43 -0700 (PDT) X-Received: by 2002:a17:903:3bd0:b0:2b0:7d3d:756a with SMTP id d9443c01a7336-2ba794c05aemr77557165ad.35.1778129082694; Wed, 06 May 2026 21:44:42 -0700 (PDT) Received: from [10.133.33.84] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babb2e5bf3sm9282825ad.83.2026.05.06.21.44.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 21:44:42 -0700 (PDT) Message-ID: <22cab2f4-1538-44e2-ac96-fb2b39d92bbf@oss.qualcomm.com> Date: Thu, 7 May 2026 12:44:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] cpufreq: sc520_freq: Drop support for AMD Elan SC520 To: Sean Young , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar Cc: linux-pm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <12a3abd097fda750ae905290c86ddb8d2b0a716c.1778071745.git.sean@mess.org> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <12a3abd097fda750ae905290c86ddb8d2b0a716c.1778071745.git.sean@mess.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDA0MyBTYWx0ZWRfX1zEHsIvLpC2J 6FOp5PFwed+gLFin565zwao1ihOCDpuMoxkX3D+xrze4EeQzMg5K/lMV38g6I5oRMIyrkDqLtwR UFQ6iALNhgJtjeqEEtJ86oI0K8/Q73N34P8f0em2wiTz63sfK04uKemf55d1cqwD0/xprS3Aw8d XyQoyA6kcmM1yLDjnS/PmcFxXv+BjTi63pkwkwTezhSu5oXKfjEJcDr+Ttf5A0q4o8+oHiPG3uJ qW1+9C7cMgP+6xa+ycAYm8Sg5Zgm/IES7hJmQY0akCrn1prsmRBsNBxe95hOPp/x37mTiI0m5ux EtwUmQv0025PbhxXmjhGKTXAGqDk9xCZp2j4yJPkhm5RXk5+KFphiiUjLyHLLhnGW1V9DWtTfit RxRF+RNKjILuIgzf5uX6iDRe4ButxktTGekcgF1uxReuyIO08R6iHI6Eie7kGJ1N+XnrVRJe6Oh LR54mxSW4CMuY63twvg== X-Proofpoint-ORIG-GUID: 8ufEjNtoMJ67iYquBV_HF_PzKkSLi0ij X-Proofpoint-GUID: 8ufEjNtoMJ67iYquBV_HF_PzKkSLi0ij X-Authority-Analysis: v=2.4 cv=ZZ4t8MVA c=1 sm=1 tr=0 ts=69fc18bb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=xGAvDSoXAAAA:8 a=EUspDBNiAAAA:8 a=PPKScp5biaQuhl8iTOUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=I9AbH5bZuplaqbmfSwNo:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070043 On 5/6/2026 10:42 PM, Sean Young wrote: > Since commit 8b793a92d862 ("x86/cpu: Remove M486/M486SX/ELAN support"), > the AMD Elan SC520 is no longer supported, so the cpu frequency > driver is no longer needed. > > Signed-off-by: Sean Young Reviewed-by: Zhongqiu Han > --- > drivers/cpufreq/Kconfig.x86 | 11 --- > drivers/cpufreq/Makefile | 1 - > drivers/cpufreq/sc520_freq.c | 136 ----------------------------------- > 3 files changed, 148 deletions(-) > delete mode 100644 drivers/cpufreq/sc520_freq.c > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index 027e6ea2e038..865b290b01ff 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -141,17 +141,6 @@ config ELAN_CPUFREQ > > If in doubt, say N. > > -config SC520_CPUFREQ > - tristate "AMD Elan SC520" > - depends on MELAN > - help > - This adds the CPUFreq driver for AMD Elan SC520 processor. > - > - For details, take a look at . > - > - If in doubt, say N. > - > - > config X86_POWERNOW_K6 > tristate "AMD Mobile K6-2/K6-3 PowerNow!" > depends on X86_32 > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > index 385c9fcc65c6..96196edf79d5 100644 > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > @@ -41,7 +41,6 @@ obj-$(CONFIG_X86_POWERNOW_K7) += powernow-k7.o > obj-$(CONFIG_X86_LONGHAUL) += longhaul.o > obj-$(CONFIG_X86_E_POWERSAVER) += e_powersaver.o > obj-$(CONFIG_ELAN_CPUFREQ) += elanfreq.o > -obj-$(CONFIG_SC520_CPUFREQ) += sc520_freq.o > obj-$(CONFIG_X86_LONGRUN) += longrun.o > obj-$(CONFIG_X86_GX_SUSPMOD) += gx-suspmod.o > obj-$(CONFIG_X86_SPEEDSTEP_ICH) += speedstep-ich.o > diff --git a/drivers/cpufreq/sc520_freq.c b/drivers/cpufreq/sc520_freq.c > deleted file mode 100644 > index b360f03a116f..000000000000 > --- a/drivers/cpufreq/sc520_freq.c > +++ /dev/null > @@ -1,136 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-or-later > -/* > - * sc520_freq.c: cpufreq driver for the AMD Elan sc520 > - * > - * Copyright (C) 2005 Sean Young > - * > - * Based on elanfreq.c > - * > - * 2005-03-30: - initial revision > - */ > - > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > - > -#include > -#include > -#include > - > -#include > -#include > -#include > -#include > - > -#include > - > -#define MMCR_BASE 0xfffef000 /* The default base address */ > -#define OFFS_CPUCTL 0x2 /* CPU Control Register */ > - > -static __u8 __iomem *cpuctl; > - > -static struct cpufreq_frequency_table sc520_freq_table[] = { > - {0, 0x01, 100000}, > - {0, 0x02, 133000}, > - {0, 0, CPUFREQ_TABLE_END}, > -}; > - > -static unsigned int sc520_freq_get_cpu_frequency(unsigned int cpu) > -{ > - u8 clockspeed_reg = *cpuctl; > - > - switch (clockspeed_reg & 0x03) { > - default: > - pr_err("error: cpuctl register has unexpected value %02x\n", > - clockspeed_reg); > - fallthrough; > - case 0x01: > - return 100000; > - case 0x02: > - return 133000; > - } > -} > - > -static int sc520_freq_target(struct cpufreq_policy *policy, unsigned int state) > -{ > - > - u8 clockspeed_reg; > - > - local_irq_disable(); > - > - clockspeed_reg = *cpuctl & ~0x03; > - *cpuctl = clockspeed_reg | sc520_freq_table[state].driver_data; > - > - local_irq_enable(); > - > - return 0; > -} > - > -/* > - * Module init and exit code > - */ > - > -static int sc520_freq_cpu_init(struct cpufreq_policy *policy) > -{ > - struct cpuinfo_x86 *c = &cpu_data(0); > - > - /* capability check */ > - if (c->x86_vendor != X86_VENDOR_AMD || > - c->x86 != 4 || c->x86_model != 9) > - return -ENODEV; > - > - /* cpuinfo and default policy values */ > - policy->cpuinfo.transition_latency = 1000000; /* 1ms */ > - policy->freq_table = sc520_freq_table; > - > - return 0; > -} > - > - > -static struct cpufreq_driver sc520_freq_driver = { > - .get = sc520_freq_get_cpu_frequency, > - .verify = cpufreq_generic_frequency_table_verify, > - .target_index = sc520_freq_target, > - .init = sc520_freq_cpu_init, > - .name = "sc520_freq", > -}; > - > -static const struct x86_cpu_id sc520_ids[] = { > - X86_MATCH_VENDOR_FAM_MODEL(AMD, 4, 9, NULL), > - {} > -}; > -MODULE_DEVICE_TABLE(x86cpu, sc520_ids); > - > -static int __init sc520_freq_init(void) > -{ > - int err; > - > - if (!x86_match_cpu(sc520_ids)) > - return -ENODEV; > - > - cpuctl = ioremap((unsigned long)(MMCR_BASE + OFFS_CPUCTL), 1); > - if (!cpuctl) { > - pr_err("sc520_freq: error: failed to remap memory\n"); > - return -ENOMEM; > - } > - > - err = cpufreq_register_driver(&sc520_freq_driver); > - if (err) > - iounmap(cpuctl); > - > - return err; > -} > - > - > -static void __exit sc520_freq_exit(void) > -{ > - cpufreq_unregister_driver(&sc520_freq_driver); > - iounmap(cpuctl); > -} > - > - > -MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Sean Young "); > -MODULE_DESCRIPTION("cpufreq driver for AMD's Elan sc520 CPU"); > - > -module_init(sc520_freq_init); > -module_exit(sc520_freq_exit); > - -- Thx and BRs, Zhongqiu Han