From: Jacob Keller <jacob.e.keller@intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jijie Shao <shaojijie@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
Hao Lan <lanhao@huawei.com>,
Peiyang Wang <wangpeiyang1@huawei.com>,
Jie Wang <wangjie125@huawei.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hns3: avoid linking objects into multiple modules
Date: Thu, 30 May 2024 10:58:57 -0700 [thread overview]
Message-ID: <22de594e-2e2b-4659-b88b-3d0e4c99e4fa@intel.com> (raw)
In-Reply-To: <20240528161603.2443125-1-arnd@kernel.org>
On 5/28/2024 9:15 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Each object file contains information about which module it gets linked
> into, so linking the same file into multiple modules now causes a warning:
>
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_cmd.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_rss.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_tqp_stats.o is added to multiple modules: hclge hclgevf
>
> Change the way that hns3 is built by moving the three common files into a
> separate module with exported symbols instead.
>
> Fixes: 5f20be4e90e6 ("net: hns3: refactor hns3 makefile to support hns3_common module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
This one has a savings of ~72Kb on my system.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-05-30 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 16:15 [PATCH] hns3: avoid linking objects into multiple modules Arnd Bergmann
2024-05-30 17:58 ` Jacob Keller [this message]
2024-05-31 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22de594e-2e2b-4659-b88b-3d0e4c99e4fa@intel.com \
--to=jacob.e.keller@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox