From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753066AbcHOQqL (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 12:46:11 -0400
Received: from saturn.retrosnub.co.uk ([178.18.118.26]:41980 "EHLO
	saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752909AbcHOQqJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 12:46:09 -0400
Subject: Re: [PATCH v4 1/4] mfd: mxs-lradc: Add support for mxs-lradc MFD
To: Lee Jones <lee.jones@linaro.org>,
        Alexander Stein <alexander.stein@systec-electronic.com>
References: <cover.1470316956.git.ksenija.stanojevic@gmail.com>
 <0a60a10b249062d305237f04fdb9aea05b128b85.1470316956.git.ksenija.stanojevic@gmail.com>
 <2721285.1CS7CJCgc7@ws-stein> <20160805070224.GH5243@dell>
Cc: linux-kernel@vger.kernel.org,
        Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
        dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
        knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, marex@denx.de,
        linux-iio@vger.kernel.org, harald@ccbib.org, stefan.wahren@i2se.com,
        fabio.estevam@freescale.com
From: Jonathan Cameron <jic23@kernel.org>
Message-ID: <22e16c7d-4ad7-6432-11e7-30b6b6194573@kernel.org>
Date: Mon, 15 Aug 2016 17:46:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160805070224.GH5243@dell>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/08/16 08:02, Lee Jones wrote:
> On Thu, 04 Aug 2016, Alexander Stein wrote:
> 
>> On Thursday 04 August 2016 15:28:18, Ksenija Stanojevic wrote:
>>> Add core files for mxs-lradc MFD driver.
>>>
>>> Note:  this patch won't compile in iio/testing without this patch:
>>> a8f447be8056 ("mfd: Add resource managed APIs for mfd_add_devices")
>>>
>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>>> ---
>>> [...]
>>> +static int mxs_lradc_probe(struct platform_device *pdev)
>>> +{
>>> +	const struct of_device_id *of_id;
>>> +	struct device *dev = &pdev->dev;
>>> +	struct device_node *node = dev->of_node;
>>> +	struct mxs_lradc *lradc;
>>> +	struct resource *iores;
>>> +	struct mfd_cell *cells = NULL;
>>> +	int ret = 0;
>>> +	u32 ts_wires = 0;
>>> +
>>> +	lradc = devm_kzalloc(&pdev->dev, sizeof(*lradc), GFP_KERNEL);
>>> +	if (!lradc)
>>> +		return -ENOMEM;
>>> +
>>> +	of_id = of_match_device(mxs_lradc_dt_ids, &pdev->dev);
>>> +	lradc->soc = (enum mxs_lradc_id)of_id->data;
>>> +
>>> +	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> +	lradc->base = devm_ioremap_resource(dev, iores);
>>
>> Out of couriosity: Is it common to pass already ioremapped addresses to (MFD 
>> cell) platform drivers? I would have expected, and done myself, that ioremap 
>> is done in the driver itself, same as the IRQ.
> 
> Yes, this is exactly what should happen.
> 
Lee, you've confused me with this answer.  Yes, it is common or Yes it
should have been done the way Alexander suggested?

Jonathan