public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"marcofrk@gmail.com" <marcofrk@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stefan@agner.ch" <stefan@agner.ch>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm
Date: Sat, 16 Jun 2018 01:29:31 +0200	[thread overview]
Message-ID: <22e2aecc-3735-8ad6-3f36-75ae2b8f2498@gmail.com> (raw)
In-Reply-To: <CAOMZO5DJju6oBRLakkTx4np7w9nMwPm6TMkGGYjbMLUPDUugYw@mail.gmail.com>

On 06/16/2018 12:22 AM, Fabio Estevam wrote:
> On Fri, Jun 15, 2018 at 6:36 PM, Marek Vasut <marex@denx.de> wrote:
> 
>> Having two drivers in the kernel with different set of bugs is always bad.
> 
> Sure, but breaking dtb's is also bad.

You picked only the first part of my argument, the less important one ;-)

> Can the mxsfb driver be modified to handle the old style bindings?

Maybe, but do we care ? Cfr my comment about the amount of users who
will be affected by this.

> The IPU drm driver is capable of handling both the old style where the
> display timing is passed in dts and the new drm style.
> 
> For example:
> 
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi uses the drm style binding
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi uses the old style of passing
> the display timings in dts
> 
> Both formats are accepted by the ipu drm driver.
> 
> Can't mxsfb drm driver support both? Then we don't need to worry about
> breaking dtb's and could safely remove the mxs fbdev driver.

This might be a way forward, but again, does it justify the effort ?
We will be adding compatibility code which we will have to maintain for
maybe a handful of users I think.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2018-06-15 23:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 19:43 [PATCH 0/3] ARM: imx: Make DRM_MXSFB and FB_MXS coexist Leonard Crestez
2018-06-15 19:43 ` [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm Leonard Crestez
2018-06-15 19:47   ` Fabio Estevam
2018-06-15 20:58     ` Leonard Crestez
2018-06-15 21:05       ` Fabio Estevam
2018-06-15 21:36       ` Marek Vasut
2018-06-15 22:22         ` Fabio Estevam
2018-06-15 23:29           ` Marek Vasut [this message]
2018-06-15 22:42         ` Leonard Crestez
2018-06-15 23:32           ` Marek Vasut
2018-06-18  7:43             ` Daniel Vetter
2018-06-18  8:13               ` Stefan Agner
2018-07-10  9:06             ` Stefan Agner
2018-07-10  9:11               ` Marek Vasut
2018-07-12  9:21                 ` Stefan Agner
2018-07-12 13:03                   ` Leonard Crestez
2018-07-12 13:14                     ` Marek Vasut
2018-07-13  7:25                       ` Daniel Vetter
2018-07-12 13:46                     ` Stefan Agner
2018-07-12 12:15                 ` Stefan Agner
2018-06-15 19:43 ` [PATCH 2/3] fbdev: mxsfb: Return ENODEV on missing display node Leonard Crestez
2018-06-15 19:43 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable DRM_MXSFB Leonard Crestez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22e2aecc-3735-8ad6-3f36-75ae2b8f2498@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcofrk@gmail.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox