Re: [PATCH] 2.5.43 CSA, Job, and PAGG

Robin Holt
2002-10-18T01:17:24Z

On 18 Oct 2002, Andi Kleen wrote:

> Christoph Hellwig <hch@sgi.com> writes:
>
> >
> > +#if defined __ia64__
> > +#define JID_ERR1 "do_csa_acct: No job table entry for jid 0x%lx.\n"
> > +#define JID_ERR2 "csa user job accounting write error %d, jid 0x%lx\n"
> > +#define JID_ERR3 "Can't disable csa user job accounting jid 0x%lx\n"
> > +#define JID_ERR4 "csa user job accounting disabled, jid 0x%lx\n"
> > +#else
> > +#define JID_ERR1 "do_csa_acct: No job table entry for jid 0x%llx.\n"
> > +#define JID_ERR2 "csa user job accounting write error %d, jid 0x%llx\n"
> > +#define JID_ERR3 "Can't disable csa user job accounting jid 0x%llx\n"
> > +#define JID_ERR4 "csa user job accounting disabled, jid 0x%llx\n"
> > +#endif
> >
> > Umm, this would be #if __LP64__. But please just always cast
> > to long long instead.
>
> __LP64__ is a HP/IA64ism, which is not necessarily defined on other
> 64bit platforms. The proper way to test for 64bit in the kernel is
>
> #include <linux/types.h>
>
> ...
>
> #if BITS_PER_LONG==64
>
> #endif
>
> -Andi
>

I did the cast to long long instead. Cleans things up nicely.

Robin