Re: [PATCH] 2.5.43 CSA, Job, and PAGG

Keith Owens
2002-10-18T15:38:00Z

On Fri, 18 Oct 2002 18:00:31 -0400,
Christoph Hellwig <hch@sgi.com> wrote:
>On Sat, Oct 19, 2002 at 12:37:50AM +1000, Keith Owens wrote:
>> The construct #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE) is
>> required for all CONFIG_FOO which can be defined as tristate.
>
>Keith, I know that it works. Which doesn't make it a good idea.

With the current config system you have to code that way if FOO can be
built in or a module. What do you mean by this?

>> On Thu, 17 Oct 2002 22:44:10 -0400,
>> Christoph Hellwig <hch@sgi.com> wrote:
>> >+#if defined (CONFIG_CSA_JOB_ACCT) || defined (CONFIG_CSA_JOB_ACCT_MODULE)
>> >Umm, stubbing stuff out based on _MODULE is a bad, bad idea. Just make it
>> >a bool instead.

With
dep_tristate ' CSA Job Accounting' CONFIG_CSA_JOB_ACCT $CONFIG_PAGG_JOB
there is no single bool which defines if CONFIG_CSA_JOB_ACCT is set or
not in .config.

There is even source code that needs to know if CONFIG_FOO was set to y
or m, that code needs the existing separation between CONFIG_FOO and
CONFIG_FOO_MODULE.