Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

Eric Biggers
2017-11-24T20:37:56Z

On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > - construct_get_dest_keyring(&dest_keyring);
>
> This will break. construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
>

Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.

Eric