Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)

Benjamin Herrenschmidt
2007-04-04T23:14:09Z

On Wed, 2007-04-04 at 11:16 +0100, David Howells wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > - if (!(flags & MAP_SHARED))
> > + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
> > + * folks there... --BenH.
> > + */
> > + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))
>
> MAP_FIXED on NOMMU? Surely you jest...

Heh, see the comment, I was actually wondering about it :-)

> See the first if-statement in validate_mmap_request().
>
> If anything, you should be adding BUG_ON(flags & MAP_FIXED).

Yeah, I missed that bit. That will simplify the problem.

Thanks,
Ben.