From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E74AC4167B for ; Mon, 27 Nov 2023 15:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233742AbjK0PBf (ORCPT ); Mon, 27 Nov 2023 10:01:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233282AbjK0PBc (ORCPT ); Mon, 27 Nov 2023 10:01:32 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47426C6; Mon, 27 Nov 2023 07:01:36 -0800 (PST) Received: from i53875bf8.versanet.de ([83.135.91.248] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7d6y-0003Fi-1u; Mon, 27 Nov 2023 16:01:24 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andy Yan Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com, s.hauer@pengutronix.de, Andy Yan Subject: Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode Date: Mon, 27 Nov 2023 16:01:22 +0100 Message-ID: <23093643.0c2gjJ1VT2@diego> In-Reply-To: <20231122125413.3454489-1-andyshrk@163.com> References: <20231122125316.3454268-1-andyshrk@163.com> <20231122125413.3454489-1-andyshrk@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan: > From: Andy Yan > > At first we thought the half_block_en bit in AFBCD_CTRL register > only work in afbc mode. But the fact is that it control the line > buffer in all mode(afbc/tile/line), so we need configure it in > all case. > > Signed-off-by: Andy Yan This looks common to the rk3568 variant, right, so I guess this should have a Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") perhaps? Heiko