From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8981F4FA2 for ; Wed, 30 Oct 2024 14:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299779; cv=none; b=qLyllfSLlcQwFhYNxoH3XpZU+B5Bm+7q5RJU/+swiJGZhUMn4H5PGX4WyQLGOtydcU9w/hdwwepmvnwumb9zfgkEJHW1jeNXZ28pAeyIOUDCV6vP5l1gZRUcZ88lnuj1lmZQqE3uwpS3sk4LWbdAb5nPokH2c+HtCa6/t/+pSPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299779; c=relaxed/simple; bh=58fkI0DxBTuYu41ZNeXJTYW9hWb+IBRT0RkNSze6a4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oqWbydVtRzBVO977u2i5+DCu02x0V1Z2yWynYWOEdk5soPlnkOeOCrfI3m8rhfoxEusnV5QvM/+e58m2/5fJDCdYNxxdCNdyyIROiL9NPnuSVQODB9olL8nAbimUdeU3Tj2fZxNSlcB+pS2SsNPklpmmH4K4aG34/AxW4+FraJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hChgAx3v; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hChgAx3v" Message-ID: <230b5910-6790-44cb-90ed-222bee89054d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730299774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1w/iqqQqeWdeidkDYmAvBZgSRrIyIu8DOwMPAJKc5Y=; b=hChgAx3vpxAGTC+OhSh6VQuCWJeMJr+0JC1YgvQs6qW6kvU5WF6nXBZ98DDucWqYkFvPkT F8TPGR9+POiRaVmvmQnWW3KABiWHhd2eHu0ra11vSqHySg4IdE4cMK03hMllBb4rkXzCm/ urjRWKw09rxXAhEPe72OlmQuYLc7t+M= Date: Wed, 30 Oct 2024 22:49:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge To: Neil Armstrong , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Abel Vesa Cc: Johan Hovold , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org> <172951608323.1285208.3162107667310691864.b4-ty@linaro.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <172951608323.1285208.3162107667310691864.b4-ty@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi, On 2024/10/21 21:08, Neil Armstrong wrote: > Hi, > > On Fri, 18 Oct 2024 15:49:34 +0300, Abel Vesa wrote: >> The assignment of the of_node to the aux bridge needs to mark the >> of_node as reused as well, otherwise resource providers like pinctrl will >> report a gpio as already requested by a different device when both pinconf >> and gpios property are present. >> Fix that by using the device_set_of_node_from_dev() helper instead. >> >> >> [...] > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes) It's quite impolite to force push patches that still under reviewing, this prevent us to know what exactly its solves. This also prevent us from finding a better solution. > [1/1] drm/bridge: Fix assignment of the of_node of the parent to aux bridge > https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/85e444a68126a631221ae32c63fce882bb18a262 > -- Best regards, Sui