Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

Bean Huo
2020-06-17T09:42:13Z

On Wed, 2020-06-17 at 14:27 +0530, Alim Akhtar wrote:
> > > > > + init_waitqueue_head(&hba->ufsf.sdev_wait);
> > > > > + atomic_set(&hba->ufsf.slave_conf_cnt, 0);
> > > > > +
> > > > > + if (hba->dev_info.wspecversion >=
> > > > > HPB_SUPPORTED_VERSION &&
> > > > > + (hba->dev_info.b_ufs_feature_sup &
> > > > > UFS_DEV_HPB_SUPPORT))
> > > >
> > > > How about removing this check "(hba->dev_info.wspecversion >=
> > > > HPB_SUPPORTED_VERSION" since ufs with lower version than v3.1
> > > > can add
> > > > HPB feature by FFU,
> > > > if (hba->dev_info.b_ufs_feature_sup
> > > > &UFS_FEATURE_SUPPORT_HPB_BIT) is
> > > > enough.
> > >
> > > OK, changing it seems no problem. But I want to know what other
> > > people
> > > think
> > > about this version checking code.
> >
> > HPB1.0 isn't part of ufs3.1, but published only later.
> > Allowing earlier versions will required to quirk the descriptor
> > sizes.
> > I see Bean's point here, but I vote for adding it in a single
> > quirk, when the time comes.
> >
>
> I second Avri here, older devices need a quirk to handle, let do that
> as a separate patch.
> > Thanks,
> > Avri
>
>

what is useful point of adding a quirk for this?

From the customer side piont, they just get our FW image, and then do
FFU. If adding a quirk here, that means they also need to change UFS
driver. Also, you expand the qurik structure.

from cambridge dictionary:
Qurik:
an unusual habit or part of someone's personality, or something
that
is strange and unexpected.

HPB feature is unexpected??

please tell me the useful point of adding a Quirk.

Bean
>