Re: [PATCH v2 4/9] media: imx: Fail conversion if pixel format not supported

Laurent Pinchart
2022-02-15T07:55:53Z

Hi Alexander and Dorota,

Thank you for the patch.

On Fri, Feb 11, 2022 at 03:27:47PM +0100, Alexander Stein wrote:
> From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
>
> imx_media_find_mbus_format has NULL as a valid return value,
> therefore the caller should take it into account.
>
> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/staging/media/imx/imx-media-utils.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 02a4cb124d37..e59aaa77172a 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -544,6 +544,9 @@ static int imx56_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> cc = imx_media_find_mbus_format(code, PIXFMT_SEL_YUV);
> }
>
> + if (!cc)
> + return -EINVAL;
> +
> /* Round up width for minimum burst size */
> width = round_up(mbus->width, 8);
>

--
Regards,

Laurent Pinchart