public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Peter Anvin <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: Linux 6.11-rc1
Date: Tue, 30 Jul 2024 13:31:18 -0600	[thread overview]
Message-ID: <231e7a2e-7e2e-4b82-b084-8943b2236de0@kernel.dk> (raw)
In-Reply-To: <20240730192237.GR33588@noisy.programming.kicks-ass.net>

On 7/30/24 1:22 PM, Peter Zijlstra wrote:
> On Tue, Jul 30, 2024 at 11:53:31AM -0700, Linus Torvalds wrote:
> 
>> Which makes me think it's asm_exc_int3 just recursively failing.
> 
> Sounds like text_poke() going sideways, there's a jump_label fail out
> there:
> 
>  https://lkml.kernel.org/r/20240730132626.GV26599@noisy.programming.kicks-ass.net

No change with this applied...

Also not sure if you read my link, but a few things to note:

- It only happens with gcc-11 here. I tried 12/13/14 and those
  are fine, don't have anything older

- It only happens with KFENCE enabled.


>> Let's see it x86 people have some idea, but that
>>
>>    restore_all_switch_stack+0x65/0xe6
>>
>> and doing an objdump to see the code generation, it is literally here:
>>
>>         0f 20 d8                mov    %cr3,%eax
>>         0d 00 10 00 00          or     $0x1000,%eax
>>         0f 22 d8                mov    %eax,%cr3
> 
> That looks like SWITCH_TO_USER_CR3
> 
>>         eb 16                   jmp    <restore_all_switch_stack+0x7d>
>>
>> with that "jmp" instruction being the restore_all_switch_stack+0x65 address.
> 
> Thish would make this BUG_IF_WRONG_CR3, which starts with an ALTERNATIVE
> jmp. I think we landed a pile of ALTERNATIVE patches this merge window.
> 
> That said, Boris did spend an awful lot of time testing them... but this
> is 32bit so who knows how much time that got.

Since I got this setup with Guenter's setup, it literally takes me seconds
to compile and test anything. So feel free to toss anything at it and we'll
see what sticks.

-- 
Jens Axboe



  reply	other threads:[~2024-07-30 19:31 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 21:40 Linux 6.11-rc1 Linus Torvalds
2024-07-29  9:28 ` Build regressions/improvements in v6.11-rc1 Geert Uytterhoeven
2024-07-29  9:35   ` Geert Uytterhoeven
2024-07-29  9:54     ` Arnd Bergmann
2024-07-29 10:07       ` Geert Uytterhoeven
2024-07-29 15:29 ` Linux 6.11-rc1 Guenter Roeck
2024-07-29 19:23   ` Linus Torvalds
2024-07-29 19:50     ` Linus Torvalds
2024-07-29 21:34       ` Arnd Bergmann
2024-07-29 23:47         ` Linus Torvalds
2024-07-30 15:47           ` Arnd Bergmann
2024-07-30  7:54     ` Peter Zijlstra
2024-07-31 15:45     ` Guenter Roeck
2024-07-30 17:04   ` Guenter Roeck
2024-07-30 17:20     ` Jens Axboe
2024-07-30 18:22       ` Guenter Roeck
2024-07-30 18:35         ` Jens Axboe
2024-07-30 18:54           ` Jens Axboe
2024-07-30 18:53     ` Linus Torvalds
2024-07-30 19:22       ` Peter Zijlstra
2024-07-30 19:31         ` Jens Axboe [this message]
2024-07-30 19:34           ` Jens Axboe
2024-07-30 19:38           ` Peter Zijlstra
2024-07-30 19:41             ` Linus Torvalds
2024-07-30 20:04             ` Guenter Roeck
2024-07-30 20:09               ` Peter Zijlstra
2024-07-30 21:12                 ` Peter Zijlstra
2024-07-30 23:29                 ` Guenter Roeck
2024-07-30 23:54                   ` Linus Torvalds
2024-07-31  8:21                     ` Borislav Petkov
2024-07-31  9:11                       ` Peter Zijlstra
2024-07-31 10:02                         ` Borislav Petkov
2024-07-31 14:37                       ` Guenter Roeck
2024-07-31 13:24                     ` Jens Axboe
2024-07-30 20:13               ` Linus Torvalds
2024-07-30 20:24             ` Guenter Roeck
2024-07-31 12:20               ` Peter Zijlstra
2024-07-31 13:03                 ` Thomas Gleixner
2024-07-31 15:55                   ` Peter Zijlstra
2024-07-31 16:17                     ` Linus Torvalds
2024-07-31 16:31                       ` Peter Zijlstra
2024-07-31 16:50                         ` Guenter Roeck
2024-07-31 16:51                         ` Peter Zijlstra
2024-07-31 17:26                           ` Thomas Gleixner
2024-07-31 21:20                             ` Peter Zijlstra
2024-07-31 21:23                               ` Linus Torvalds
2024-07-31 21:26                                 ` Peter Zijlstra
2024-07-31 21:41                                   ` Linus Torvalds
2024-07-31 21:47                                     ` Thomas Gleixner
2024-07-31 22:22                               ` Guenter Roeck
2024-08-01  8:54                                 ` Peter Zijlstra
2024-08-01 10:55                         ` [tip: x86/urgent] x86/mm: Fix pti_clone_pgtable() alignment assumption tip-bot2 for Peter Zijlstra
2024-08-01 13:03                         ` tip-bot2 for Peter Zijlstra
2024-07-31 16:49                       ` Linux 6.11-rc1 Guenter Roeck
2024-07-31 17:19                         ` Thomas Gleixner
2024-07-31 10:33       ` Peter Zijlstra
2024-07-31 14:15         ` Peter Zijlstra
2024-08-02 17:35   ` Linus Walleij
2024-08-02 19:40     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=231e7a2e-7e2e-4b82-b084-8943b2236de0@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox