* CONFIG_ACPI totally broken (2.6.9-rc1-mm2) @ 2004-08-31 19:08 Martin J. Bligh 2004-08-31 19:13 ` Martin J. Bligh 2004-09-01 0:55 ` Roman Zippel 0 siblings, 2 replies; 6+ messages in thread From: Martin J. Bligh @ 2004-08-31 19:08 UTC (permalink / raw) To: linux-kernel OK, not only does it not compile in -mm2, you also can't disable it. Moreover, if you try you get this: scripts/kconfig/mconf arch/i386/Kconfig Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830 larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config # CONFIG_HPET_TIMER is not set # CONFIG_X86_HT is not set # CONFIG_PCI_GOMMCONFIG is not set # CONFIG_HPET is not set larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config # Power management options (ACPI, APM) # ACPI (Advanced Configuration and Power Interface) Support CONFIG_ACPI=y # CONFIG_ACPI_AC is not set # CONFIG_ACPI_BATTERY is not set # CONFIG_ACPI_BUTTON is not set # CONFIG_ACPI_FAN is not set # CONFIG_ACPI_PROCESSOR is not set # CONFIG_ACPI_ASUS is not set # CONFIG_ACPI_TOSHIBA is not set # CONFIG_ACPI_DEBUG is not set CONFIG_ACPI_EC=y CONFIG_ACPI_PCI=y How the hell do you turn this stuff off? M. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_ACPI totally broken (2.6.9-rc1-mm2) 2004-08-31 19:08 CONFIG_ACPI totally broken (2.6.9-rc1-mm2) Martin J. Bligh @ 2004-08-31 19:13 ` Martin J. Bligh 2004-08-31 19:27 ` Andrew Morton 2004-09-01 0:55 ` Roman Zippel 1 sibling, 1 reply; 6+ messages in thread From: Martin J. Bligh @ 2004-08-31 19:13 UTC (permalink / raw) To: linux-kernel; +Cc: Andrew Morton > OK, not only does it not compile in -mm2, you also can't disable it. The exact same config file works fine in -mm1 ... it's just the -mm2 one that's broken. > Moreover, if you try you get this: > > scripts/kconfig/mconf arch/i386/Kconfig > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI > Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830 > > larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config ># CONFIG_HPET_TIMER is not set ># CONFIG_X86_HT is not set ># CONFIG_PCI_GOMMCONFIG is not set ># CONFIG_HPET is not set > > larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config ># Power management options (ACPI, APM) ># ACPI (Advanced Configuration and Power Interface) Support > CONFIG_ACPI=y ># CONFIG_ACPI_AC is not set ># CONFIG_ACPI_BATTERY is not set ># CONFIG_ACPI_BUTTON is not set ># CONFIG_ACPI_FAN is not set ># CONFIG_ACPI_PROCESSOR is not set ># CONFIG_ACPI_ASUS is not set ># CONFIG_ACPI_TOSHIBA is not set ># CONFIG_ACPI_DEBUG is not set > CONFIG_ACPI_EC=y > CONFIG_ACPI_PCI=y > > How the hell do you turn this stuff off? > > M. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_ACPI totally broken (2.6.9-rc1-mm2) 2004-08-31 19:13 ` Martin J. Bligh @ 2004-08-31 19:27 ` Andrew Morton 2004-08-31 19:41 ` Martin J. Bligh 0 siblings, 1 reply; 6+ messages in thread From: Andrew Morton @ 2004-08-31 19:27 UTC (permalink / raw) To: Martin J. Bligh; +Cc: linux-kernel, linux-acpi "Martin J. Bligh" <mbligh@aracnet.com> wrote: > > > OK, not only does it not compile in -mm2, you also can't disable it. > > The exact same config file works fine in -mm1 ... it's just the -mm2 > one that's broken. > > > Moreover, if you try you get this: > > > > scripts/kconfig/mconf arch/i386/Kconfig > > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC > > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI > > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI > > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC > > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI > > Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830 Yeah, that one. I bugged Len the other day, but perhaps he's out of town or something. > > larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config > ># CONFIG_HPET_TIMER is not set > ># CONFIG_X86_HT is not set > ># CONFIG_PCI_GOMMCONFIG is not set > ># CONFIG_HPET is not set > > > > larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config > ># Power management options (ACPI, APM) > ># ACPI (Advanced Configuration and Power Interface) Support > > CONFIG_ACPI=y > ># CONFIG_ACPI_AC is not set > ># CONFIG_ACPI_BATTERY is not set > ># CONFIG_ACPI_BUTTON is not set > ># CONFIG_ACPI_FAN is not set > ># CONFIG_ACPI_PROCESSOR is not set > ># CONFIG_ACPI_ASUS is not set > ># CONFIG_ACPI_TOSHIBA is not set > ># CONFIG_ACPI_DEBUG is not set > > CONFIG_ACPI_EC=y > > CONFIG_ACPI_PCI=y > > > > How the hell do you turn this stuff off? > > > > M. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_ACPI totally broken (2.6.9-rc1-mm2) 2004-08-31 19:27 ` Andrew Morton @ 2004-08-31 19:41 ` Martin J. Bligh 0 siblings, 0 replies; 6+ messages in thread From: Martin J. Bligh @ 2004-08-31 19:41 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, linux-acpi, Sam Ravnborg >> > OK, not only does it not compile in -mm2, you also can't disable it. >> >> The exact same config file works fine in -mm1 ... it's just the -mm2 >> one that's broken. OK, removing all the "select ACPI" statements from arch/i386/Kconfig fixes it ... but all of the things that those were under were already disabled. So I think it might be a Kconfig bug. ftp://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/config.numaq should demonstrate it well. >> > Moreover, if you try you get this: >> > >> > scripts/kconfig/mconf arch/i386/Kconfig >> > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC >> > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI >> > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI >> > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC >> > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI >> > Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830 > > Yeah, that one. I bugged Len the other day, but perhaps he's > out of town or something. Nah, he's talking to me on IRC, so he can't escape ;-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_ACPI totally broken (2.6.9-rc1-mm2) 2004-08-31 19:08 CONFIG_ACPI totally broken (2.6.9-rc1-mm2) Martin J. Bligh 2004-08-31 19:13 ` Martin J. Bligh @ 2004-09-01 0:55 ` Roman Zippel 1 sibling, 0 replies; 6+ messages in thread From: Roman Zippel @ 2004-09-01 0:55 UTC (permalink / raw) To: Martin J. Bligh; +Cc: linux-kernel, Andrew Morton Hi, On Tue, 31 Aug 2004, Martin J. Bligh wrote: > scripts/kconfig/mconf arch/i386/Kconfig > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC > Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI > Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830 The patch below fixes these warnings. This usage of select is really bad, as it made it impossible to just enable PCI_BIOS and PCI_DIRECT without turning on ACPI. I seriously consider to add a timeout after such warnings or even turn them into errors, currently they are too easily ignored. :( bye, Roman diff -ur linux-2.6.org/arch/i386/Kconfig linux-2.6/arch/i386/Kconfig --- linux-2.6.org/arch/i386/Kconfig 2004-08-31 21:26:53.000000000 +0200 +++ linux-2.6/arch/i386/Kconfig 2004-09-01 01:35:31.000000000 +0200 @@ -1120,6 +1120,7 @@ config PCI_GOMMCONFIG bool "MMConfig" + depends on ACPI config PCI_GODIRECT bool "Direct" @@ -1130,20 +1131,14 @@ endchoice config PCI_BIOS - bool - depends on !X86_VISWS && PCI && (PCI_GOBIOS || PCI_GOANY) - default y + def_bool PCI_GOBIOS || PCI_GOANY config PCI_DIRECT - bool - depends on PCI && ((PCI_GODIRECT || PCI_GOANY) || X86_VISWS) - default y + def_bool PCI_GODIRECT || PCI_GOANY || X86_VISWS config PCI_MMCONFIG - bool - depends on PCI && (PCI_GOMMCONFIG || (PCI_GOANY && ACPI)) - select ACPI - default y + def_bool PCI_GOMMCONFIG || PCI_GOANY + depends on ACPI source "drivers/pci/Kconfig" diff -ur linux-2.6.org/drivers/char/drm/Kconfig linux-2.6/drivers/char/drm/Kconfig --- linux-2.6.org/drivers/char/drm/Kconfig 2004-08-31 21:27:01.000000000 +0200 +++ linux-2.6/drivers/char/drm/Kconfig 2004-09-01 01:45:13.000000000 +0200 @@ -55,9 +55,13 @@ selected, the module will be called i810. AGP support is required for this driver to work. +choice + prompt "Intel 830M, 845G, 852GM, 855GM, 865G (915G)" + depends on DRM && AGP && AGP_INTEL + optional + config DRM_I830 - tristate "Intel 830M, 845G, 852GM, 855GM, 865G" - depends on DRM && AGP && AGP_INTEL && !(DRM_I915=y) + tristate "Old driver" help Choose this option if you have a system that has Intel 830M, 845G, 852GM, 855GM or 865G integrated graphics. If M is selected, the @@ -67,15 +71,15 @@ or previous releases. config DRM_I915 - tristate "Intel 830M, 845G, 852GM, 855GM, 865G, 915G" - depends on DRM && AGP && AGP_INTEL && !(DRM_I830=y) + tristate "New driver" help Choose this option if you have a system that has Intel 830M, 845G, 852GM, 855GM 865G or 915G integrated graphics. If M is selected, the module will be called i915. AGP support is required for this driver to work. This driver should be used for systems running Xorg 6.8 and XFree86 releases after (but not including 4.4). - + +endchoice config DRM_MGA tristate "Matrox g200/g400" ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <566B962EB122634D86E6EE29E83DD808182C4C12@hdsmsx403.hd.intel.com>]
* Re: CONFIG_ACPI totally broken (2.6.9-rc1-mm2) [not found] <566B962EB122634D86E6EE29E83DD808182C4C12@hdsmsx403.hd.intel.com> @ 2004-09-01 1:47 ` Len Brown 0 siblings, 0 replies; 6+ messages in thread From: Len Brown @ 2004-09-01 1:47 UTC (permalink / raw) To: Martin J. Bligh; +Cc: Andrew Morton, linux-kernel, linux-acpi, Sam Ravnborg [-- Attachment #1: Type: text/plain, Size: 372 bytes --] Martin, Looks like having a config item simultaneously depend on something and select it is a bad idea;-) Let me know if this patch fixes the symptoms you see. With your config and this patch I'm able to de-select X86_HT and ACPI, which I think is what you were looking for, yes? Andrew, thanks for spotting this earlier -- sorry I didn't get back sooner. thanks, -Len [-- Attachment #2: kconfig.patch --] [-- Type: text/plain, Size: 343 bytes --] ===== arch/i386/Kconfig 1.130 vs edited ===== --- 1.130/arch/i386/Kconfig Tue Aug 31 02:10:41 2004 +++ edited/arch/i386/Kconfig Tue Aug 31 21:35:30 2004 @@ -1141,7 +1141,7 @@ config PCI_MMCONFIG bool - depends on PCI && (PCI_GOMMCONFIG || (PCI_GOANY && ACPI)) + depends on PCI && (PCI_GOMMCONFIG || PCI_GOANY) select ACPI default y ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-09-01 1:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-31 19:08 CONFIG_ACPI totally broken (2.6.9-rc1-mm2) Martin J. Bligh
2004-08-31 19:13 ` Martin J. Bligh
2004-08-31 19:27 ` Andrew Morton
2004-08-31 19:41 ` Martin J. Bligh
2004-09-01 0:55 ` Roman Zippel
[not found] <566B962EB122634D86E6EE29E83DD808182C4C12@hdsmsx403.hd.intel.com>
2004-09-01 1:47 ` Len Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox