From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: next-20190826 - objtool fails to build.
Date: Wed, 28 Aug 2019 15:30:00 -0400 [thread overview]
Message-ID: <23345.1567020600@turing-police> (raw)
In-Reply-To: <20190828151003.3px5plk4tp2s5s5c@treble>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Wed, 28 Aug 2019 10:10:04 -0500, Josh Poimboeuf said:
> But I don't see how those warnings could get enabled: -Wsign-compare
> -Wunused-parameter.
>
> Can you "make clean" and do "make V=1 tools/objtool" to show the actual
> flags?
And that tells me those warnings in fact don't get specifically enabled.
(I've added some line breaks for sanity)
gcc -Wp,-MD,/usr/src/linux-next/tools/objtool/.special.o.d -Wp,-MT,/usr/src/linux-next/tools/objtool/special.o -O2 -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wbad-function-cast
Found the cause of the mystery - I changed something in a bash profile, and
as a result...
export CFLAGS="-O2 -D_FORTIFY_SOURCE=2 -Wall -Wextra"
And -Wextra pulls in the things that cause problems. So this is mostly
self-inflicted.
The real question then becomes - should the Makefile sanitize CFLAGS or just
append to whatever the user supplied as it does currently? The rest of the tree
sanitizes CFLAG, because I don't get deluged in -Wsign-compare warnings all
over the place...
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-08-28 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 4:15 next-20190826 - objtool fails to build Valdis Klētnieks
2019-08-28 15:10 ` Josh Poimboeuf
2019-08-28 19:30 ` Valdis Klētnieks [this message]
2019-08-28 19:51 ` Josh Poimboeuf
2019-08-28 19:58 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23345.1567020600@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox