From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8290C2D131A; Tue, 9 Dec 2025 14:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288883; cv=none; b=pineNOCmWxodm+dk8I1usVInoO8rYEK3/0GWJjI4qMqm1PtOhmtTceuQ9ZaVBvulcg8AYdWX3xrRBGQjmho7N2QPccaIVoG5rCTQRXlgfcdCYaJgqfkP4ykb+1+Y+n+yanYC7y85axXNLk9O5JPqhP2OgLVwPo1PH5Zcv5owQ14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288883; c=relaxed/simple; bh=CVZQ9243uQdk0W2AonSWy0bOS/2S3BmJSxPZ6gHQqU8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Xz4QRUa/jq2wJqQ7E+FkL9N3ahvjQ8Qd+LD80eFDkVzL5zKsxi9Eeaod3Mss+tt7jgv8k/mHNHRHqMiWVXcpdS2hbpG2UPdNQd2H2Mbktszf8AyqYK7qvCc5TP+LDw9YJXI8+jkPem/ZFDtvEaNkUg/S6QzdwzGjhUh60XRy3kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A0cVenlM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A0cVenlM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C43ECC113D0; Tue, 9 Dec 2025 14:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765288883; bh=CVZQ9243uQdk0W2AonSWy0bOS/2S3BmJSxPZ6gHQqU8=; h=From:To:Cc:Subject:Date:From; b=A0cVenlMeNo4u6xCGtDpcnaQ1GRZ/wyI6AoyW7dnuaYxc01dGATAhkLRcfO3IUbjD l1fucU6vB4/xse36ITJQQ+ux8HkKUhVNltRUIr6CTTQLXD94EHWtLYaVq4peSszXtg yL15xAUS5dL9KJGIFuUKnsR15jNkhjryt87sbCFKcFukZlckCBkZPZYzLGSfLrxWtH Uv8Z6RDBcprMIuZKoBi6qNYdUF7eG6tdOJCnh7LkghrvbuqGmq6ZJeI5OjOJdL37zw DLyNUQypA2Y+gQaBBf9Ie8HaOHzyzoQuS4s78eqKBonzxGWW7ofkL0vhDw6/E1VTU7 9O9OehRXYcjUA== From: "Rafael J. Wysocki" To: Linux ACPI Cc: Hans de Goede , LKML , Linux PM , Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Armin Wolf Subject: [PATCH v1 10/10] ACPI: Convert button and battery drivers to platform ones Date: Tue, 09 Dec 2025 14:49:38 +0100 Message-ID: <2339822.iZASKD2KPV@rafael.j.wysocki> Organization: Linux Kernel Development Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Hi All, While binding drivers directly to struct acpi_device objects allows basic functionality to be provided, at least in the majority of cases, there are some problems with it, related to general consistency, sysfs layout, power management operation ordering, and code cleanliness. First of all, struct acpi_device objects represent firmware entities rather than hardware and in many cases they provide auxiliary information on devices enumerated independently (like PCI devices or CPUs). It is therefore generally questionable to assign resources to them or create class devices and similar under them because they don't provide functionality associated with those entities by themselves (for example, they don't generate wakeup or input events). As a general rule, a struct acpi_device can only be a parent of another struct acpi_device. If that's not the case, the location of the child device in the device hierarchy is at least confusing and it may not be straightforward to identify the piece of hardware corresponding to that device. Using system suspend and resume callbacks directly with struct acpi_device objects is questionable either because it may cause ordering problems to happen. Namely, struct acpi_device objects are registered before any devices corresponded to by them and they land on the PM list before all of those devices. Consequently, the execution ordering of their PM callbacks may be different from what is generally expected. Moreover, dependencies returned by _DEP objects don't generally affect struct acpi_device objects themselves, only the "physical" device objects associated with them, which potentially is one more source of inconsistency. All of the above means that binding drivers to struct acpi_device "devices" should generally be avoided and so this series converts three generic ACPI device drivers, the button driver, the tiny power button driver, and the battery driver, to platform drivers. Patches [01-03/10] are preliminary for the button driver conversions. Patch [01/10] causes platform devices to be registered for "fixed event device" buttons, patch [02/10] cleans up the "fixed event device" registration code, and patch [03/10] rearranges the notification handling code in the button driver to use internal "button" structures for passing data instead of struct acpi_device objects. Patches [04-05/10] convert the two button drivers to platform ones and patches [06-07/10] do some cleanups on top of them. Patches [08-09/10] are preliminary for the battery driver conversion which is carried out in patch [10/10]. Thanks!