public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Gabriel Gonzales" <semfault@disroot.org>,
	"Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"Biswapriyo Nath" <nathbappai@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges
Date: Tue, 13 Jan 2026 09:53:39 +0100	[thread overview]
Message-ID: <233f73de-b247-4b22-a079-5bd3f5ece5cd@oss.qualcomm.com> (raw)
In-Reply-To: <20260112-xiaomi-willow-v1-2-8e4476897638@mainlining.org>

On 1/12/26 9:13 PM, Barnabás Czémán wrote:
> The device was crashing on high memory load because the reserved memory
> ranges was wrongly defined. Correct the ranges for avoid the crashes.
> Change the ramoops memory range to match with the values from the recovery
> to be able to get the results from the device.
> 
> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 44 ++++++++++++++++-------
>  1 file changed, 32 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> index bf03226a6f85..4c548cb5f253 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> @@ -13,6 +13,12 @@
>  #include "sm6125.dtsi"
>  #include "pm6125.dtsi"
>  
> +/delete-node/ &adsp_pil_mem;
> +/delete-node/ &cont_splash_mem;
> +/delete-node/ &gpu_mem;
> +/delete-node/ &ipa_fw_mem;
> +/delete-node/ &ipa_gsi_mem;
> +
>  / {
>  	model = "Xiaomi Redmi Note 8";
>  	compatible = "xiaomi,ginkgo", "qcom,sm6125";
> @@ -36,28 +42,42 @@ framebuffer0: framebuffer@5c000000 {
>  	};
>  
>  	reserved-memory {
> -		debug_mem: debug@ffb00000 {
> -			reg = <0x0 0xffb00000 0x0 0xc0000>;
> +		adsp_pil_mem: adsp_pil_mem@55300000 {
> +			reg = <0x0 0x55300000 0x0 0x2200000>;
>  			no-map;
>  		};
>  
> -		last_log_mem: lastlog@ffbc0000 {
> -			reg = <0x0 0xffbc0000 0x0 0x80000>;
> +		ipa_fw_mem: ipa_fw_mem@57500000 {
> +			reg = <0x0 0x57500000 0x0 0x10000>;
>  			no-map;
>  		};
>  
> -		pstore_mem: ramoops@ffc00000 {
> -			compatible = "ramoops";
> -			reg = <0x0 0xffc40000 0x0 0xc0000>;
> -			record-size = <0x1000>;
> -			console-size = <0x40000>;
> -			pmsg-size = <0x20000>;
> +		ipa_gsi_mem: ipa_gsi_mem@57510000 {
> +			reg = <0x0 0x57510000 0x0 0x5000>;
> +			no-map;
>  		};
>  
> -		cmdline_mem: memory@ffd00000 {
> -			reg = <0x0 0xffd40000 0x0 0x1000>;
> +		gpu_mem: gpu_mem@57515000 {
> +			reg = <0x0 0x57515000 0x0 0x2000>;
>  			no-map;
>  		};
> +
> +		framebuffer@5c000000 {
> +			reg = <0x0 0x5c000000 0x0 (2340 * 1080 * 4)>;
> +			no-map;
> +		};
> +
> +		/*
> +		 * Matching with recovery values
> +		 * to be able to get the results.
> +		 */

/* This is an unnecessarily
 * squashed comment that could
 * easily go into a single line
 */


> +		ramoops@61600000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0x61600000 0x0 0x400000>;
> +			record-size = <0x80000>;
> +			pmsg-size = <0x200000>;
> +			console-size = <0x100000>;

Does your recovery image not specify ecc-size?

In my past experience, that led to much better results wrt the data
being actually readable.. you might want to rebuild your recovery (or
at least the dt and repack the boot.img) for that

Konrad

  reply	other threads:[~2026-01-13  8:53 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 20:13 [PATCH 0/6] Initial Redmi Note 8T support and more Barnabás Czémán
2026-01-12 20:13 ` [PATCH 1/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix msm-id and remove board-id Barnabás Czémán
2026-01-12 22:11   ` Dmitry Baryshkov
2026-01-13  8:52   ` Konrad Dybcio
2026-01-14  9:10   ` Krzysztof Kozlowski
2026-01-12 20:13 ` [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges Barnabás Czémán
2026-01-13  8:53   ` Konrad Dybcio [this message]
2026-01-13  9:14     ` barnabas.czeman
2026-01-13  9:21       ` Konrad Dybcio
2026-01-14 10:15   ` David Heidelberg
2026-01-14 10:28     ` Konrad Dybcio
2026-01-14 21:55       ` David Heidelberg
2026-01-16  9:52         ` Konrad Dybcio
2026-01-16 11:21           ` David Heidelberg
2026-01-16 11:30             ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 3/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Remove extcon Barnabás Czémán
2026-01-12 22:12   ` Dmitry Baryshkov
2026-01-13  8:59   ` Konrad Dybcio
2026-01-13  9:00   ` Konrad Dybcio
2026-01-13  9:11     ` barnabas.czeman
2026-01-13  9:13       ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges Barnabás Czémán
2026-01-13  9:01   ` Konrad Dybcio
2026-01-13  9:08     ` barnabas.czeman
2026-01-13  9:12       ` Konrad Dybcio
2026-01-13  9:25         ` barnabas.czeman
2026-01-13  9:45           ` Konrad Dybcio
2026-01-13 14:13             ` Biswapriyo Nath
2026-01-12 20:13 ` [PATCH 5/6] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8T Barnabás Czémán
2026-01-15 17:37   ` Rob Herring (Arm)
2026-01-12 20:13 ` [PATCH 6/6] arm64: dts: qcom: Add " Barnabás Czémán
2026-01-12 22:15   ` Dmitry Baryshkov
2026-01-12 23:41     ` barnabas.czeman
2026-01-13  0:22       ` Dmitry Baryshkov
2026-01-13  0:49         ` barnabas.czeman
2026-01-13  1:18           ` Dmitry Baryshkov
2026-01-13  8:52           ` Konrad Dybcio
2026-01-13  9:20             ` barnabas.czeman
2026-01-13  9:04   ` Konrad Dybcio
2026-01-16  6:53     ` barnabas.czeman
2026-01-16  9:53       ` Konrad Dybcio
2026-01-16 10:51         ` barnabas.czeman
2026-01-16 11:03           ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=233f73de-b247-4b22-a079-5bd3f5ece5cd@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mainlining.org \
    --cc=nathbappai@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=semfault@disroot.org \
    --cc=tony.luck@intel.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox