Re: [PATCH 26/30] ARM: omap: add board autoselection

Santosh Shilimkar
2011-10-03T05:28:33Z

On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote:
> At least one board file needs to be selected to successfully build
> a kernel, so this one adds logic to the omap Kconfig file to
> pick one default board file when all others are disabled. Since
> the available boards depend on the SoC family (omap2/3/4) being
> selected first, this adds one default for each family.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-omap2/Kconfig | 39 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 3c9fb89..fd0ab18 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -120,6 +120,45 @@ config MACH_OMAP_GENERIC
> depends on ARCH_OMAP2
> default y
>
> +config MACH_OMAP_AUTO_BOARD
> + def_bool y
> + depends on !MACH_OMAP2_TUSB6010
> + depends on !MACH_OMAP_H4
> + depends on !MACH_OMAP_APOLLON
> + depends on !MACH_OMAP_APOLLON
> + depends on !MACH_OMAP_2430SDP
> + depends on !MACH_OMAP3_BEAGLE
> + depends on !MACH_DEVKIT8000
> + depends on !MACH_OMAP_LDP
> + depends on !MACH_OMAP3530_LV_SOM
> + depends on !MACH_OMAP3_TORPEDO
> + depends on !MACH_OVERO
> + depends on !MACH_OMAP3EVM
> + depends on !MACH_OMAP3517EVM
> + depends on !MACH_CRANEBOARD
> + depends on !MACH_OMAP3_PANDORA
> + depends on !MACH_OMAP3_TOUCHBOOK
> + depends on !MACH_NOKIA_N8X0
> + depends on !MACH_NOKIA_RM680
> + depends on !MACH_NOKIA_RX51
> + depends on !MACH_OMAP_ZOOM2
> + depends on !MACH_OMAP_ZOOM3
> + depends on !MACH_CM_T35
> + depends on !MACH_CM_T3517
> + depends on !MACH_IGEP0020
> + depends on !MACH_IGEP0030
> + depends on !MACH_SBC3530
> + depends on !MACH_OMAP_3630SDP
> + depends on !MACH_TI8168EVM
> + depends on !MACH_OMAP4_PANDA
Do we need all above 'depends on *' ?
Even if they get selected for one of the below
ARCH along with default machine, build should be happy.
Right ?

> + select MACH_OMAP_GENERIC if ARCH_OMAP2
> + select MACH_OMAP_3430SDP if ARCH_OMAP3 && !ARCH_OMAP2
> + select MACH_OMAP_4430SDP if ARCH_OMAP4 && !ARCH_OMAP3 && !ARCH_OMAP2
This is fine.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>