Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

Felipe Balbi
2011-10-10T06:10:34Z

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

On Sun, Oct 02, 2011 at 04:45:45PM +0200, Arnd Bergmann wrote:
> The logic to allow only one DMA driver in MUSB is currently
> flawed, because it also allows picking no DMA driver at all
> and also not selecting PIO mode.
>
> Using a choice statement makes this foolproof for now and
> also simplifies the Makefile.
>
> Unfortunately, we will have to revisit this when we start
> supporting multiple ARM platforms in a single kernel binary,
> because at that point we will actually need to select
> multiple DMA drivers and pick the right one at run-time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Felipe Balbi <balbi@ti.com>

applied, thanks

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]