From: Heiko Stuebner <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Wenrui Li <wenrui.li@rock-chips.com>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback
Date: Fri, 28 Oct 2016 10:31:00 +0200 [thread overview]
Message-ID: <2348307.ygIaYT7LcH@phil> (raw)
In-Reply-To: <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com>
Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin:
> The deassert of phy_rst from exit callback is incorrect as when
> doing phy_exit, we expect the phy_rst is on asserted state which was
> done by power_off callback, but not deasserted state. Meanwhile when
> disabling clk_pciephy_ref, the assert/deassert signal can't actually
> take effect on the phy. So let's fix it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
looks ok to have that removed, as any future phy_init call will make sure it
gets asserted anyway.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next parent reply other threads:[~2016-10-28 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com>
2016-10-28 8:31 ` Heiko Stuebner [this message]
2016-11-05 5:48 ` [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2348307.ygIaYT7LcH@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=jeffy.chen@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=wenrui.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox