From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759636AbcJ1IbK (ORCPT ); Fri, 28 Oct 2016 04:31:10 -0400 Received: from gloria.sntech.de ([95.129.55.99]:60590 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755938AbcJ1IbI (ORCPT ); Fri, 28 Oct 2016 04:31:08 -0400 From: Heiko Stuebner To: Shawn Lin Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Jeffy Chen , Wenrui Li , Brian Norris Subject: Re: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback Date: Fri, 28 Oct 2016 10:31:00 +0200 Message-ID: <2348307.ygIaYT7LcH@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.26.0; x86_64; ; ) In-Reply-To: <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com> References: <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin: > The deassert of phy_rst from exit callback is incorrect as when > doing phy_exit, we expect the phy_rst is on asserted state which was > done by power_off callback, but not deasserted state. Meanwhile when > disabling clk_pciephy_ref, the assert/deassert signal can't actually > take effect on the phy. So let's fix it anyway. > > Signed-off-by: Shawn Lin looks ok to have that removed, as any future phy_init call will make sure it gets asserted anyway. Reviewed-by: Heiko Stuebner