From: Keith Owens <kaos@ocs.com.au>
To: Dave Jones <davej@suse.de>
Cc: linux-kernel@vger.kernel.org, davem@redhat.com
Subject: Re: [patch] 2.5.25 net/core/Makefile
Date: Tue, 09 Jul 2002 12:13:30 +1000 [thread overview]
Message-ID: <23502.1026180810@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Tue, 09 Jul 2002 02:36:28 +0200." <20020709023628.A1697@suse.de>
On Tue, 9 Jul 2002 02:36:28 +0200,
Dave Jones <davej@suse.de> wrote:
>On Tue, Jul 09, 2002 at 10:30:31AM +1000, Keith Owens wrote:
> > > > The valid combination of CONFIG_NET=n, CONFIG_LLC undefined incorrectly
> > >And this breaks the valid combination of CONFIG_NET=y, CONFIG_LLC undef'd
>
> > ??? That is the bug that I reported. My patch fixes that bug.
>
>Same bug maybe, but triggered in different ways.
>Note the CONFIG_NET change between your report and mine.
Sorry, missed that change the first time.
The problem is net/802/Makefile which includes p8022 for any of
CONFIG_LLC, CONFIG_TR, CONFIG_IPX or CONFIG_ATALK. p8022 calls
llc_register_sap which is in ext8022.o, that file is built by
net/core/Makefile but only for CONFIG_LLC. It worked before because of
the wrong test in net/core/Makefile which always built ext8022.o.
Davem - we could unconditionally build ext8022.o when CONFIG_NET=y or
we could do this
Index: 25.1/net/core/Makefile
--- 25.1/net/core/Makefile Wed, 19 Jun 2002 14:11:35 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
+++ 25.1(w)/net/core/Makefile Tue, 09 Jul 2002 12:10:53 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
@@ -16,7 +16,8 @@ obj-$(CONFIG_FILTER) += filter.o
obj-$(CONFIG_NET) += dev.o dev_mcast.o dst.o neighbour.o rtnetlink.o utils.o
-ifneq ($(CONFIG_LLC),n)
+# See p8022 in net/802/Makefile for config options to check
+ifneq ($(subst n,,$(CONFIG_LLC)$(CONFIG_TR)$(CONFIG_IPX)$(CONFIG_ATALK)),)
obj-y += ext8022.o
endif
Index: 25.1/net/802/Makefile
--- 25.1/net/802/Makefile Fri, 21 Jun 2002 10:09:01 +1000 kaos (linux-2.5/r/c/0_Makefile 1.3 444)
+++ 25.1(w)/net/802/Makefile Tue, 09 Jul 2002 12:10:38 +1000 kaos (linux-2.5/r/c/0_Makefile 1.3 444)
@@ -6,6 +6,7 @@ export-objs := llc_macinit.o p8022.o ps
obj-y := p8023.o
+# Check the p8022 selections against net/core/Makefile.
obj-$(CONFIG_SYSCTL) += sysctl_net_802.o
obj-$(CONFIG_LLC) += p8022.o psnap.o llc_sendpdu.o llc_utility.o \
cl2llc.o llc_macinit.o
next prev parent reply other threads:[~2002-07-09 2:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-06 8:30 [patch] 2.5.25 net/core/Makefile Keith Owens
2002-07-09 0:11 ` Dave Jones
2002-07-09 0:30 ` Keith Owens
2002-07-09 0:36 ` Dave Jones
2002-07-09 2:13 ` Keith Owens [this message]
2002-07-09 2:24 ` Arnaldo Carvalho de Melo
2002-07-21 23:56 ` Kai Germaschewski
2002-07-22 1:08 ` Keith Owens
2002-07-22 8:07 ` Russell King
2002-07-22 8:37 ` Roman Zippel
2002-07-22 8:51 ` Andreas Schwab
2002-07-22 8:55 ` Russell King
2002-07-22 9:23 ` Roman Zippel
2002-07-22 14:29 ` Kai Germaschewski
-- strict thread matches above, loose matches on Subject: below --
2002-07-11 3:53 Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23502.1026180810@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=davej@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox