Re: [PATCH] RDMA/siw: Remove direct link to net_device

Jason Gunthorpe
2024-12-11T16:00:57Z

On Tue, Dec 10, 2024 at 05:52:37PM -0800, Jakub Kicinski wrote:
> On Tue, 10 Dec 2024 10:56:27 -0400 Jason Gunthorpe wrote:
> > > struct siw_device {
> > > struct ib_device base_dev;
> > > - struct net_device *netdev;
> > > struct siw_dev_cap attrs;
> > >
> > > u32 vendor_part_id;
> > > + struct {
> > > + int ifindex;
> >
> > ifindex is only stable so long as you are holding a reference on the
> > netdev..
>
> Does not compute. Can you elaborate what you mean, Jason?

I mean you can't replace a netdev pointer with an ifindex, you can't
reliably get back to the same netdev from ifindex alone.

Jason