Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

Lucas Stach
2014-04-03T08:33:09Z

Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri:
> Arnd,
>
> Thanks for reviewing the RFC patch. Please see below my response.
>
> On 3/25/2014 3:44 AM, Arnd Bergmann wrote:
> > On Monday 24 March 2014 20:35:26 Murali Karicheri wrote:
[...]
>
> >> + ks_pcie->clk = devm_clk_get(&pdev->dev, "pcie");
> >> + if (IS_ERR(ks_pcie->clk)) {
> >> + dev_err(&pdev->dev, "Failed to get pcie rc clock\n");
> >> + return PTR_ERR(ks_pcie->clk);
> >> + }
> >> + ret = clk_prepare_enable(ks_pcie->clk);
> >> + if (ret)
> >> + return ret;
> > Could you move the clock handling into the generic dw-pcie code?
>
> Could be. But currently only pci-exynos.c is using a clock name
> "pcie".pci-imx6.c uses pcie_axi" and
> will have to be fixed so that we can move this code to the generic
> dw-pcie code. Sean Cross is the
> author for pci-imx6.c.
>
> Sean,
>
> Is "pcie_axi" is the pcie hw clock? If so, can you rename this to "pcie"
> so that my patch can move the
> clock handling code to pcie designware code?
>
My series "i.MX6 PCIe binding change and MSI support" already changes
the clock name. So we could consolidate the clock handling once this is
in. Only difference is that the i.MX6 needs an additional PHY clock.

Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |