From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757259Ab0DIJLA (ORCPT ); Fri, 9 Apr 2010 05:11:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12410 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188Ab0DIJK6 (ORCPT ); Fri, 9 Apr 2010 05:10:58 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1270792042-9358-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <1270792042-9358-1-git-send-email-paulmck@linux.vnet.ibm.com> <20100409054701.GA8833@linux.vnet.ibm.com> To: "Paul E. McKenney" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, eric.dumazet@gmail.com Subject: Re: [PATCH tip/core/urgent 1/4] rcu: add rcu_access_pointer and rcu_dereference_protected Date: Fri, 09 Apr 2010 10:10:11 +0100 Message-ID: <23572.1270804211@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul E. McKenney wrote: > +#define rcu_access_pointer(p) ((void *)ACCESS_ONCE(p)) > ... > +#define rcu_access_pointer(p) ((void *)ACCESS_ONCE(p)) There's no difference between your two versions of rcu_access_pointer(), so you could move that whole construct outside of the #ifdef'ed section. Other than that: Acked-by: David Howells