From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758754AbbA2W2u (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Jan 2015 17:28:50 -0500
Received: from mout.kundenserver.de ([212.227.17.13]:58940 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753418AbbA2W2t (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Jan 2015 17:28:49 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "moderated list:ARM/S5P EXYNOS AR..." 
	<linux-arm-kernel@lists.infradead.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Mark Brown <broonie@kernel.org>,
        =?ISO-8859-1?Q?S=F6ren?= Brinkmann <soren.brinkmann@xilinx.com>,
        linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers
Date: Thu, 29 Jan 2015 23:28:15 +0100
Message-ID: <2357790.QEsOKkOOBx@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAPybu_0OWLZeEFMByrrDg7HOfjAYbOnAoazLac-E8KV-mKSJSg@mail.gmail.com>
References: <1422543073-21895-1-git-send-email-ricardo.ribalda@gmail.com> <2800334.5ezTSQFkNQ@wuerfel> <CAPybu_0OWLZeEFMByrrDg7HOfjAYbOnAoazLac-E8KV-mKSJSg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:e7mWo4ADCPwaFMdDgJGJQBFgN/bCjoMyqPgQpakEkgFH6/xjN/8
 6jaal4M37FLgevedzVHrglrZlPrWhwptX7/psOZyzaXX4HV/tvr3UFyMI9wO/GFHwD8KTVf
 1TKFKimRSRGuh4MaLj3i/oQ0sYqxiKIq8x2HfC4nfE1wq5py7/kgNnvJ+dXw4hugtDbTRmI
 HoMsIvHBOZuaVr5ixHhhA==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 29 January 2015 23:14:46 Ricardo Ribalda Delgado wrote:
> What about the different return type? u8 vs int

Too many drivers use all sorts of different types, I've given up
hope of changing drivers to agree on the same type here. Basically
you can think of 'void __iomem *' as the magic keyword for something
that gets returned from ioremap, can take an integer offset and gets
passed into readb/readw/readl/write..., but any other assumption beyond
that is dangerous.

	Arnd