From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>, vkoul@kernel.org
Cc: alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com,
amadeuszx.slawinski@linux.intel.com, Mastan.Katragadda@amd.com,
Arungopal.kondaveeti@amd.com, claudiu.beznea@microchip.com,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V7 2/8] soundwire: amd: Add support for AMD Manager driver
Date: Fri, 10 Mar 2023 10:45:03 -0600 [thread overview]
Message-ID: <235cf556-10a9-c461-e4bf-700ab8c32d51@linux.intel.com> (raw)
In-Reply-To: <20230310162554.699766-3-Vijendar.Mukunda@amd.com>
On 3/10/23 10:25, Vijendar Mukunda wrote:
> AMD ACP(v6.x) IP block has two SoundWire manager devices.
> Add support for
> - Manager driver probe & remove sequence
> - Helper functions to enable/disable interrupts,
> Initialize sdw manager, enable sdw pads
> - Manager driver sdw_master_ops & port_ops callbacks
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Apart from debatable style issues in the way local variables are exposed
(inconsistent use of multiple variables/line, random variations to
reverse x-mas tree), this looks good enough to me for an initial
contribution.
Thanks for bearing with my feedback.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2023-03-10 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
2023-03-10 16:25 ` [PATCH V7 1/8] soundwire: export sdw_compute_slave_ports() function Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 2/8] soundwire: amd: Add support for AMD Manager driver Vijendar Mukunda
2023-03-10 16:45 ` Pierre-Louis Bossart [this message]
2023-03-10 16:25 ` [PATCH V7 3/8] soundwire: amd: register SoundWire manager dai ops Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 4/8] soundwire: amd: enable build for AMD SoundWire manager driver Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 5/8] soundwire: amd: add SoundWire manager interrupt handling Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 6/8] soundwire: amd: add runtime pm ops for AMD SoundWire manager driver Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 7/8] soundwire: amd: handle SoundWire wake enable interrupt Vijendar Mukunda
2023-03-10 16:25 ` [PATCH V7 8/8] soundwire: amd: add pm_prepare callback and pm ops support Vijendar Mukunda
2023-03-10 16:46 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235cf556-10a9-c461-e4bf-700ab8c32d51@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Arungopal.kondaveeti@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox