Re: [PATCH 4/4] iommu: make inclusion of riscv directory conditional

[Rolf Eike Beer <eb@emlix.com>]

[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]

On Donnerstag, 20. März 2025 09:07:29 Mitteleuropäische Normalzeit Joerg 
Roedel wrote:
> On Tue, Mar 11, 2025 at 11:15:12AM +0100, Rolf Eike Beer wrote:
> > Nothing in there is active if CONFIG_RISCV_IOMMU is not enabled, so the
> > whole directory can depend on that switch as well.
> > 
> > Fixes: 5c0ebbd3c6c6 ("iommu/riscv: Add RISC-V IOMMU platform device
> > driver") Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> > ---
> > 
> >  drivers/iommu/Makefile | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
> > index 41b00cdc8621..17133876f777 100644
> > --- a/drivers/iommu/Makefile
> > +++ b/drivers/iommu/Makefile
> > @@ -1,7 +1,8 @@
> > 
> >  # SPDX-License-Identifier: GPL-2.0
> > 
> > -obj-y += arm/ iommufd/ riscv/
> > +obj-y += arm/ iommufd/
> > 
> >  obj-$(CONFIG_AMD_IOMMU) += amd/
> >  obj-$(CONFIG_INTEL_IOMMU) += intel/
> > 
> > +obj-$(CONFIG_RISCV_IOMMU) += riscv/
> > 
> >  obj-$(CONFIG_IOMMU_API) += iommu.o
> >  obj-$(CONFIG_IOMMU_API) += iommu-traces.o
> >  obj-$(CONFIG_IOMMU_API) += iommu-sysfs.o
> 
> This allows for some additional cleanups in the Makefiles of the
> sub-directory, no? Same for the other patches in this series.

Yes, and I can send those cleanups as a followup if you like. But for the first 
step I wanted to keep this as less invasive as it could be. And to be honest I 
didn't want to invest time to do this cleanups if it's unclear if they would 
be rejected anyway because these things are this way on purpose.

Regards,

Eike
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]