From: Keith Owens <kaos@ocs.com.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH][2.6] Completely out of line spinlocks / i386
Date: Thu, 12 Aug 2004 10:01:50 +1000 [thread overview]
Message-ID: <23701.1092268910@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Wed, 11 Aug 2004 15:13:15 MST." <Pine.LNX.4.58.0408111511380.1839@ppc970.osdl.org>
On Wed, 11 Aug 2004 15:13:15 -0700 (PDT),
Linus Torvalds <torvalds@osdl.org> wrote:
>
>
>On Wed, 11 Aug 2004, Pavel Machek wrote:
>>
>> Fine, so perhaps we do not want config option?
>
>The inline spinlocks are _wonderful_ for seeing where the contention is in
>a simple profile.
>
>In contrast, in a profile the out-of-lines ones will show "x% was spent on
>spinlocks". Which doesn't help much when you want to see where the problem
>is.
>
>This was _hugely_ useful, at least for me, for seeing what locks were
>problematic.
Tweak the profile code to detect that the instruction pointer is in the
out of line spinlock code and replace the ip with the caller's ip. We
already do that for ia64, where the out of line spinlock code is a big
win. A kdb backtrace on an ia64 contended lock will even decode the
address of the lock, which is only possible because the lock address is
in a known location for this case.
next prev parent reply other threads:[~2004-08-12 0:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 4:49 [PATCH][2.6] Completely out of line spinlocks / i386 Zwane Mwaikambo
2004-08-08 5:01 ` Linus Torvalds
2004-08-08 5:17 ` Zwane Mwaikambo
2004-08-08 5:21 ` Linus Torvalds
2004-08-08 6:00 ` Zwane Mwaikambo
2004-08-08 12:33 ` Andreas Schwab
2004-08-08 18:26 ` Zwane Mwaikambo
2004-08-11 21:59 ` Pavel Machek
2004-08-11 22:13 ` Linus Torvalds
2004-08-11 22:23 ` William Lee Irwin III
2004-08-12 0:01 ` Keith Owens [this message]
2004-08-12 0:39 ` David S. Miller
2004-08-12 0:54 ` Zwane Mwaikambo
2004-08-12 1:01 ` William Lee Irwin III
2004-08-12 1:37 ` Zwane Mwaikambo
2004-08-12 2:04 ` William Lee Irwin III
2004-08-12 7:20 ` William Lee Irwin III
2004-08-12 7:23 ` William Lee Irwin III
2004-08-12 7:25 ` William Lee Irwin III
2004-08-12 8:12 ` Zwane Mwaikambo
2004-08-12 8:11 ` William Lee Irwin III
2004-08-12 8:54 ` William Lee Irwin III
2004-08-13 8:01 ` William Lee Irwin III
2004-08-13 9:16 ` William Lee Irwin III
2004-08-13 9:30 ` William Lee Irwin III
2004-08-13 9:46 ` William Lee Irwin III
2004-08-13 10:05 ` William Lee Irwin III
2004-08-13 10:23 ` William Lee Irwin III
2004-08-13 10:39 ` William Lee Irwin III
2004-08-13 14:15 ` Zwane Mwaikambo
2004-08-13 14:29 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23701.1092268910@ocs3.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox