Re: [PATCH 2/2] regulator: gpio: Warn if an invalid regulator-type is supplied

Laurent Pinchart
2013-12-05T20:10:29Z

Hi Mark,

Thank you for the patch.

On Thursday 05 December 2013 19:12:02 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>

I believe you could squash this patch with the one you've previously posted
that makes the property optional. For the result,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/regulator/gpio-regulator.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/regulator/gpio-regulator.c
> b/drivers/regulator/gpio-regulator.c index 13ec94d984ca..c0a1d00b78c9
> 100644
> --- a/drivers/regulator/gpio-regulator.c
> +++ b/drivers/regulator/gpio-regulator.c
> @@ -210,6 +210,9 @@ of_get_gpio_regulator_config(struct device *dev, struct
> device_node *np) config->type = REGULATOR_VOLTAGE;
> else if (!strncmp("current", regtype, 7))
> config->type = REGULATOR_CURRENT;
> + else
> + dev_warn(dev, "Unknown regulator-type '%s'\n",
> + regtype);
> }
>
> return config;
--
Regards,

Laurent Pinchart