Re: [PATCH 1/2] regulator: gpio: Document regulator-type property

Laurent Pinchart
2013-12-05T20:08:59Z

Hi Mark,

Thank you for the patch.

On Thursday 05 December 2013 19:12:01 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index
> 63c659800c03..aaf5f66e66fb 100644
> --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> @@ -10,6 +10,8 @@ Optional properties:
> - gpios : GPIO group used to control voltage.
> - startup-delay-us : Startup time in microseconds.
> - enable-active-high : Polarity of GPIO is active high (default is low).
> +- regulator-type : Specifies what is being regulated, must be either
> + "voltage" or "current"

What about adding "The type defaults to voltage if unspecified." ?

> Any property defined as part of the core regulator binding defined in
> regulator.txt can also be used.

--
Regards,

Laurent Pinchart