Re: [RFC][PATCH v021 7/9] PM: EM: Register perf domains with ho :active_power() callbacks

Rafael J. Wysocki
2024-12-16T11:59:13Z

On Mon, Dec 16, 2024 at 11:59 AM Dietmar Eggemann
<dietmar.eggemann@arm.com> wrote:
>
> On 29/11/2024 17:15, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> In Subject:
>
> with ho :active_power() - without ?
> ^^^^^^^

Sure, thanks!

> [...]
>
> > @@ -594,7 +599,19 @@ int em_dev_register_perf_domain(struct d
> > * All CPUs of a domain must have the same
> > * micro-architecture since they all share the same
> > * table.
> > + *
> > + * If the :active_power() callback is present, the
> > + * performance values for different states in the table
> > + * computed by em_create_perf_table() depend on the CPU
> > + * capacity which therefore must be the same for all
> > + * CPUs in the domain. However, if the :active_power()
> > + * callback is not NULL, em_create_perf_table() doesn't
>
> s/is not NULL/is NULL ?
>
> [...]

Yeah, one negation too many, thanks!