From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbcHPMK3 (ORCPT ); Tue, 16 Aug 2016 08:10:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:52518 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbcHPMK1 (ORCPT ); Tue, 16 Aug 2016 08:10:27 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Finlye Xiao Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, robh+dt@kernel.org, frowand.list@gmail.com, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, mark.rutland@arm.com, khilman@kernel.org, nm@ti.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, wxt@rock-chips.com, jay.xu@rock-chips.com, rocky.hao@rock-chips.com, tim.chen@rock-chips.com, tony.xie@rock-chips.com, ulysses.huang@rock-chips.com, lin.huang@rock-chips.com Subject: Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. Date: Tue, 16 Aug 2016 14:09:52 +0200 Message-ID: <23748508.K8gp1eOYRv@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1471315139-28285-3-git-send-email-finley.xiao@rock-chips.com> References: <1471315139-28285-1-git-send-email-finley.xiao@rock-chips.com> <1471315139-28285-3-git-send-email-finley.xiao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finley, Am Dienstag, 16. August 2016, 10:38:58 schrieb Finlye Xiao: > From: Finley Xiao > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao for people reading along, this simply duplicates what of_property_read_s32 already does, only for indexed properties. But I do have one issue below. > --- > drivers/of/base.c | 23 +++++++++++++++++++++++ > include/linux/of.h | 10 ++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 7792266..346457d 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1200,6 +1200,29 @@ int of_property_read_u32_index(const struct > device_node *np, EXPORT_SYMBOL_GPL(of_property_read_u32_index); > > /** > + * of_property_read_s32_index - Find and read a s32 from a multi-value > property. + * > + * @np: device node from which the property value is to be read. > + * @propname: name of the property to be searched. > + * @index: index of the u32 in the list of values > + * @out_value: pointer to return value, modified only if no error. > + * > + * Search for a property in a device node and read nth 32-bit value from > + * it. Returns 0 on success, -EINVAL if the property does not exist, > + * -ENODATA if property does not have a value, and -EOVERFLOW if the > + * property data isn't large enough. > + * > + * The out_value is modified only if a valid s32 value can be decoded. > + */ > +int of_property_read_s32_index(const struct device_node *np, > + const char *propname, u32 index, s32 *out_value) > +{ > + return of_property_read_u32_index(np, propname, index, > + (u32 *)out_value); > +} > +EXPORT_SYMBOL_GPL(of_property_read_s32_index); I think this could very well live directly in the of.h header below of_property_read_s32 or so. As this also only calls the more generic u32 variant, it can be just a static inline there and does not need to duplicate the whole stub voodoo, as the of_property_read_u32_index will also generate the -ENOSYS error in the !OF case. Heiko