From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes
Date: Mon, 23 Oct 2017 18:41:09 +0200 [thread overview]
Message-ID: <2378464.EmIP6ut5sV@bentobox> (raw)
In-Reply-To: <20160425133950.GH3381@prodigo>
[-- Attachment #1.1: Type: text/plain, Size: 3253 bytes --]
On Montag, 25. April 2016 21:39:50 CEST Antonio Quartulli wrote:
> On Mon, Apr 25, 2016 at 03:25:22PM +0200, Denys Vlasenko wrote:
> > This function compiles to 473 bytes of machine code.
> > 21 callsites.
> >
> > text data bss dec hex filename
> > 95903266 20860288 35991552 152755106 91adba2 vmlinux_before
> > 95894242 20860288 35991552 152746082 91ab862 vmlinux
>
> Hi Danys,
>
> thanks for your patch. This function is used in a several performance critical
> code paths (i.e. packet forwarding).
>
> Are we sure we are not losing in performance here?
Tested it with 2x OM5P-ACv2 (LEDE 17.01) which were connected via ethernet
cable on port eth1. iperf was started with reduced MSS to increase the packet
count on a PC which was connected to eth0:
$ iperf -c 192.168.10.1 -t 30 -i 1 -P8 -M 536 -y C > test01.csv
Another PC (running on the eth0 of the other device) was running the iperf-server.
The network configuration was modified to automatically enable bat0 when link was detected on eth1:
config interface 'loopback'
option ifname 'lo'
option proto 'static'
option ipaddr '127.0.0.1'
option netmask '255.0.0.0'
config globals 'globals'
option ula_prefix 'fdcb:4e2a:b274::/48'
config interface 'lan'
option type 'bridge'
option ifname 'eth0 bat0'
option proto 'static'
option ipaddr '192.168.1.2'
option netmask '255.255.255.0'
option ip6assign '60'
config interface 'batnet'
option mtu '1532'
option proto 'batadv'
option ifname 'eth1'
option mesh 'bat0'
test run | without patch (MiBit/s) | with patch (MiBit/s) | without batman-adv (MiBit/s)
---------+-------------------------+----------------------+-----------------------------
1 | 289 | 271 | 501
2 | 260 | 271 | 500
3 | 262 | 272 | 501
4 | 262 | 270 | 500
5 | 267 | 270 | 499
6 | 270 | 269 | 500
7 | 271 | 268 | 501
8 | 271 | 268 | 501
9 | 271 | 269 | 500
10 | 271 | 268 | 497
11 | 261 | 269 | 500
12 | 271 | 264 | 499
13 | 274 | 268 | 502
=========+=========================+======================+=============================
avg | 269 | 269 | 500
Kind regards,
Sven
[-- Attachment #1.2: tests.tar.xz --]
[-- Type: application/x-xz-compressed-tar, Size: 62496 bytes --]
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-23 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:25 [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes Denys Vlasenko
2016-04-25 13:39 ` Antonio Quartulli
2016-04-25 13:45 ` Denys Vlasenko
2016-04-25 14:19 ` Antonio Quartulli
2017-10-23 16:41 ` Sven Eckelmann [this message]
2016-04-29 21:15 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2378464.EmIP6ut5sV@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox