From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932295AbdCJBox (ORCPT ); Thu, 9 Mar 2017 20:44:53 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:33751 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbdCJBou (ORCPT ); Thu, 9 Mar 2017 20:44:50 -0500 Subject: Re: [PATCH v2 net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII To: Doug Berger References: <20170310005850.10808-1-opendmb@gmail.com> <20170310005850.10808-7-opendmb@gmail.com> Cc: pgynther@google.com, jaedon.shin@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <23787c1d-c897-eaa5-dda5-49607ac3617d@gmail.com> Date: Thu, 9 Mar 2017 17:44:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310005850.10808-7-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2017 04:58 PM, Doug Berger wrote: > When using the internal PHY it must be powered up when the MII is probed > or the PHY will not be detected. Since the PHY is powered up at reset > this has not been a problem. However, when the kernel is restarted with > kexec the PHY will likely be powered down when the kernel starts so it > will not be detected and the Ethernet link will not be established. > > This commit explicitly powers up the internal PHY when the GENET driver > is probed to correct this behavior. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian