From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14DA91F5433 for ; Wed, 17 Sep 2025 01:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758072684; cv=none; b=cHk3SvmFb4LXvEEmWrwnf4vKDPfQYCss62brDuif4pQahPWiIB4xL/Pwk7H6d7MFz1KoySecI9JdD0nLkdLTkWF/rmSoxbrv0IvpsIzvuLuQkcEp8+C74XjP07S2dy3BHg93utnvwcHz9vImrNR2affbZZo9CeqvAZx02Akk0ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758072684; c=relaxed/simple; bh=u5lW0pLv9+4EhUqqIY0EojsmYLqqRNzsPVGJzyPzyTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ee3SP+q3PQ4nKKQUqvlwl5RkBiY8BFYFF3pCf5Zr8UCul/vWxlwAQCqavjcwRTwQHXBvu7zoqv5gf0AlmaV7t6M/a2LuHL4taseij4CjdaIJBjk1n8/btANQ2iysEskRng/ZC/RSuyuOEV0Dl0PXc1cxyAZs8LItkjikrNXCDNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NsCimc8J; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NsCimc8J" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758072678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMoURYW4sWpgUzsRJYLqTrN7wpP/NRlYSdFQVLQpJhU=; b=NsCimc8J7ba8Gd+n1xwEGaiyX/ESmyzNZnAV/C6ZU8u9xl4Pf0AwM5gJP8jaNqgSwgQvpz tBBwvfDQktfmuF9biYsR3cDnByOHS1zDySMHxK+4O1klIFh+1v9BgKzajt/Vt8fH/DFAsM C4hFu3mtfydmYcFki3ulbJRMlCR51iI= From: Menglong Dong To: Alexei Starovoitov Cc: Peter Zijlstra , Alexei Starovoitov , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Mel Gorman , Valentin Schneider , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , tzimmermann@suse.de, simona.vetter@ffwll.ch, Jani Nikula , LKML , bpf Subject: Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline Date: Wed, 17 Sep 2025 09:30:50 +0800 Message-ID: <2383379.ElGaqSPkdT@7940hx> In-Reply-To: References: <20250828060354.57846-1-menglong.dong@linux.dev> <5041847.31r3eYUQgx@7940hx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Migadu-Flow: FLOW_OUT On 2025/9/17 09:29 Alexei Starovoitov write: > On Tue, Sep 16, 2025 at 6:26=E2=80=AFPM Menglong Dong wrote: > > > > On 2025/9/16 19:07 Peter Zijlstra write: > > > On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote: > > > > > > > +/* The "struct rq" is not available here, so we can't access the > > > > + * "runqueues" with this_cpu_ptr(), as the compilation will fail in > > > > + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr(): > > > > + * typeof((ptr) + 0) > > > > + * > > > > + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here. > > > > + */ > > > > > > Please fix broken comment style while you fix that compile error. > > > > It's a little embarrassing. The compile error is caused by the commit > > 1b93c03fb319 ("rcu: add rcu_read_lock_dont_migrate()") in bpf-next tree, > > which uses migrate_enable/migrate_disable in include/linux/rcupdate.h > > but include the . > > > > I can fix it by replace the linux/preempt.h with linux/sched.h, but sho= uld > > I fix it in this series? I mean, the commit 1b93c03fb319 doesn't exist = in > > the tip for now :/ >=20 > If it's just a different include then go for it. > Make sure there are no nasty build issues during the merge window. OK! >=20