From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Gordon <david.s.gordon@intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
jbottomley@odin.com
Subject: Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer
Date: Wed, 20 May 2015 22:31:45 +0200 [thread overview]
Message-ID: <2386515.9NuRN4zp72@wuerfel> (raw)
In-Reply-To: <20150520125329.d63f66765a552efa69a45038@linux-foundation.org>
On Wednesday 20 May 2015 12:53:29 Andrew Morton wrote:
> On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > I can't decide if this is actually a good idea, or if we should rather drop
> > the sg_pcopy_from_buffer() patch. Maybe someone else sees a better solution.
>
> Could make do_device_access() call sg_copy_buffer() directly.
>
> But yes, dropping the sg_pcopy_from/to_buffer changes is reasonable.
> sg_copy_buffer() is bidirectional and that won't be changing, so
> putting constified wrapeprs around it is kinda fake.
Ok. The part I only saw now is that do_device_access() is the only user
of sg_pcopy_from_buffer(), so if that passes a non-const argument,
there is dropping the patch will be teh best solution.
Arnd
next prev parent reply other threads:[~2015-05-20 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 21:22 [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer Arnd Bergmann
2015-05-20 19:53 ` Andrew Morton
2015-05-20 20:31 ` Arnd Bergmann [this message]
2015-05-21 11:09 ` Dave Gordon
2015-05-21 11:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2386515.9NuRN4zp72@wuerfel \
--to=arnd@arndb.de \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david.s.gordon@intel.com \
--cc=jbottomley@odin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox