From: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"Christian König" <christian.koenig@amd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace
Date: Tue, 17 May 2022 13:00:17 +0200 [thread overview]
Message-ID: <2386810.irdbgypaU6@pc-42> (raw)
In-Reply-To: <ca9866f0-622d-a55c-ded5-48b32340de51@amd.com>
On Tuesday 17 May 2022 11:37:27 CEST Christian König wrote:
> Am 17.05.22 um 10:32 schrieb Jérôme Pouiller:
> > [add stable@vger.kernel.org to the recipients]
>
> Well, that's not what I suggested :)
>
> The question was if we should add a CC stable tag while pushing this.
>
> Greg might be complaining that you shouldn't CC the stable list manually.
He did :). I was indeed unaware of this process.
> > On Tuesday 17 May 2022 09:30:24 CEST Christian König wrote:
> >> Am 17.05.22 um 09:27 schrieb Jerome Pouiller:
> >>> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >>>
> >>> The typedefs u32 and u64 are not available in userspace. Thus user get
> >>> an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B:
> >>>
> >>> $ gcc -Wall -c -MMD -c -o ioctls_list.o ioctls_list.c
> >>> In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1,
> >>> from /usr/include/linux/ioctl.h:5,
> >>> from /usr/include/asm-generic/ioctls.h:5,
> >>> from ioctls_list.c:11:
> >>> ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function)
> >>> 463 | { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h
> >>> | ^~~~~~~~~~~~~~~~~~
> >>> ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function)
> >>> 464 | { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h
> >>> | ^~~~~~~~~~~~~~~~~~
> >>>
> >>> The issue was initially reported here[1].
> >>>
> >>>
> >>> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >> Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
> >>
> >> CC: stable?
> > Done
> >
> >> Fixes: ?
> > Fixes: a5bff92eaac4 ("dma-buf: Fix SET_NAME ioctl uapi")
>
> Going to push that to drm-misc-fixes with the Fixes: and CC: stable tag
> added.
--
Jérôme Pouiller
next prev parent reply other threads:[~2022-05-17 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:27 [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace Jerome Pouiller
2022-05-17 7:30 ` Christian König
2022-05-17 8:32 ` Jérôme Pouiller
2022-05-17 9:37 ` Christian König
2022-05-17 11:00 ` Jérôme Pouiller [this message]
2022-05-17 9:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2386810.irdbgypaU6@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=jason@jlekstrand.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pekka.paalanen@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox